From 34d4d736397811686df2f65548f2ef0e0c0a42a8 Mon Sep 17 00:00:00 2001 From: Tony Meyer Date: Thu, 19 Dec 2024 09:13:10 +1300 Subject: [PATCH] With the benchmark tests in a separate folder, no need to change pyproject.toml Ideally, we would statically check these, like the other tests, but it does not seem super important for benchmarking tests. The issue is that there is an import after a sys.path manipulation, and pyright cannot figure that out, so complains about a lot of things. We do not want to have that charm on the path, and adjusting the path for pyright does not seem great either. Not clear what the cleanest solution is. --- pyproject.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 87e198f4d..ff6611ff7 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -206,7 +206,6 @@ builtins-ignorelist = ["id", "min", "map", "range", "type", "TimeoutError", "Con [tool.pyright] include = ["ops/*.py", "ops/_private/*.py", "test/*.py", "test/charms/*/src/*.py", "testing/src/*.py"] -exclude = ["test/test_benchmark.py"] pythonVersion = "3.8" # check no python > 3.8 features are used pythonPlatform = "All" typeCheckingMode = "strict"