Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cert handler] do not observe rel broken directly #99

Merged
merged 9 commits into from
Jun 19, 2024
Merged

[cert handler] do not observe rel broken directly #99

merged 9 commits into from
Jun 19, 2024

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jun 17, 2024

Issue

We attempt to generate a CSR on relation broken.

Solution

  • Do not observe rel broken directly
  • Do not generate CSR on rel broken

Addresses canonical/istio-operators#441.

Context

Testing Instructions

Upgrade Notes

@sed-i sed-i marked this pull request as ready for review June 17, 2024 21:50
@sed-i sed-i requested a review from a team as a code owner June 17, 2024 21:50
@DnPlas DnPlas mentioned this pull request Jun 17, 2024
Closed
PietroPasotti
PietroPasotti previously requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really like to see at least one test to guard against regressions

@sed-i sed-i requested a review from PietroPasotti June 18, 2024 19:33
@PietroPasotti
Copy link
Contributor

PietroPasotti commented Jun 19, 2024 •
edited
Loading

I wonder how this is related to #95
Same repro steps, different errors.

and if this is the right solution. Have we done some manual/integration testing on this?

@sed-i sed-i merged commit 74f192c into main Jun 19, 2024
13 checks passed
@sed-i sed-i deleted the sed-i-patch-1 branch June 19, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sed-i @PietroPasotti