Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivy job fix #4760

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Trivy job fix #4760

merged 1 commit into from
Nov 27, 2024

Conversation

maci3jka
Copy link
Contributor

@maci3jka maci3jka commented Nov 27, 2024 •
edited by louiseschmidtgen
Loading

Summary

The Trivy job started failing due to changes in trivi action code. This PR gets rid of that action and replaces it with usage of trivy binary since it is used in next steps as well.

Changes

  • Replaces Trivy install script with action installing it
  • Replaces scan action with script working in the same way
  • Updates upload-sarif action version to 3

Testing

Possible Regressions

Checklist

  • Read the contributions page.
  • Submitted the CLA form, if you are a first time contributor.
  • The introduced changes are covered by unit and/or integration tests.

Notes

@maci3jka maci3jka requested review from ktsakalozos, louiseschmidtgen and a team November 27, 2024 13:21
louiseschmidtgen
louiseschmidtgen approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for addressing the failing test!

@maci3jka maci3jka merged commit ff13a81 into master Nov 27, 2024
12 checks passed
@maci3jka maci3jka deleted the KU-2230/trivy-job-fix branch November 27, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louiseschmidtgen louiseschmidtgen louiseschmidtgen approved these changes

@ktsakalozos ktsakalozos Awaiting requested review from ktsakalozos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maci3jka @louiseschmidtgen