Make cilium cni.exclusive configurable #838
Merged
+77
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrutlucian94
force-pushed
the
cni-exclusive
branch
from
274c334
to
5c9e6a3
Compare
petrutlucian94
changed the title
petrutlucian94
force-pushed
the
cni-exclusive
branch
from
5c9e6a3
to
5581161
Compare
bschimke95
reviewed
Nov 25, 2024
We'll add an annotation, making the cilium "cni.exclusive" setting configurable. This will allow using additional CNIs such as Multus.
* use "cni.exclusive=false" by default * only check if the annotation is set, do not expect an actual boolean value * s/AnnotationCniExclusive/AnnotationCNIExclusive
petrutlucian94
force-pushed
the
cni-exclusive
branch
from
d85c328
to
7449524
Compare
bschimke95
approved these changes
Nov 26, 2024
|
We need to merge the other PR first and then bump the requirement. |
Some docs are generated based on the k8s-snap-api docstrings. We've just bumped the k8s-snap-api version and the docs are out of sync because of a spelling fix. To fix the docs CI job, we need to apply this fix here as well. In the future, we may want to remove automatically generated docs from the Github repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll add an annotation, making the cilium "cni.exclusive" setting configurable. This will allow using additional CNIs such as Multus.
Requires: canonical/k8s-snap-api#20
Fixes: #796