Cleans up all containerd-related resources on snap removal #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiubelu
force-pushed
the
fixes-containerd-cleanup
branch
from
a3eb526
to
0aca04b
Compare
claudiubelu
force-pushed
the
fixes-containerd-cleanup
branch
3 times, most recently
from
0a5091c
to
dc330e9
Compare
Currently, when removing the snap, the /var/run/containerd folder is not properly removed, as it is a folder. This fixes this issue. Additionally removes other containerd-related folders: /etc/containerd and /var/lib/containerd. We're also removing /opt/cni/bin on snap removal, which is created when bootstrapping the node. As we're removing the k8s snap, we no longer need this folder either.
claudiubelu
force-pushed
the
fixes-containerd-cleanup
branch
from
dc330e9
to
f866fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when removing the snap, the
/var/run/containerdfolder is not properly removed, as it is a folder. This fixes this issue.Additionally removes other containerd-related folders:
/etc/containerdand/var/lib/containerd.We're also removing
/opt/cni/binon snap removal, which is created when bootstrapping the node. As we're removing the k8s snap, we no longer need this folder either.