Add ceph-csi how-to (Juju) #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrutlucian94
force-pushed
the
ceph_docs
branch
from
da04874
to
b875cf7
Compare
nhennigan
reviewed
Nov 21, 2024
We're adding a guide that describes the steps to deploy Ceph and the Ceph CSI plugin using Juju. It mostly follows the steps outlined in the ceph-csi readme: https://github.com/charmed-kubernetes/ceph-csi-operator/blob/main/README.md
petrutlucian94
force-pushed
the
ceph_docs
branch
from
b875cf7
to
6eaa8f7
Compare
Whops, forgot to add that. I've updated the PR, thanks! |
edited the language to be more in line with a how-to guide rather than tutorial. Also changes to layout and heading
|
I made some changes to your PR. It was mainly styling. Once you have a read through to make sure it still all makes sense go ahead and merge. Great work 😄 |
nhennigan
approved these changes
Nov 22, 2024
petrutlucian94
commented
Nov 25, 2024
There was a problem hiding this comment.
@nhennigan thanks for making these changes! I think we should keep the juju deploy k8s example, maybe even add an explicit note about the vm resources. By default, it will allocate a single vm cpu, which isn't enough and some k8s services and pods will hang.
VM containers will default to 1 vcpu, which isn't enough for K8s. K8s services and pods will hang unless we allocate enough resources. We'll readd the "juju k8s deploy" example and an explicit note on resource requirements.
|
LGTM. You can go ahead and merge. Thanks for all your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding a guide that describes the steps to deploy Ceph and the Ceph CSI plugin using Juju.
It mostly follows the steps outlined in the ceph-csi charm readme: https://github.com/charmed-kubernetes/ceph-csi-operator/blob/main/README.md