Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotsos on arm64 nodes is taking too long in some cases #850

Open
nishant-dash opened this issue Apr 29, 2024 · 4 comments
Open

hotsos on arm64 nodes is taking too long in some cases #850

nishant-dash opened this issue Apr 29, 2024 · 4 comments
Assignees

Comments

@nishant-dash
Copy link

nishant-dash commented Apr 29, 2024

In investigating an issue with stale ports in ovn, I found that one some arm64 nodes, ovn has a lot (anywhere between 30-800) stale port entries on a host with no associated tap devices. This requires manual cleanup using ovs-vsctl like so ovs-vsctl del-port br-int ...

When trying to run hotsos on this affected node (with stale ports), hotsos takes a really long time and had to be killed.

On a non-affected node (that has 2 ports in ovn however), hotsos runs in a few seconds.

The hotsos command I am using is

hotsos --openvswitch --kernel --openstack --system

hotsos version: 1.17.0+1276~ubuntu22.04.1

@xmkg
Copy link
Contributor

xmkg commented Apr 30, 2024

Hi @nishant-dash

Is it the same when you grab a sosreport from that node and feed it to the hotsos? If so, an example sosreport would be useful to dig into this issue.

@dosaboy
Copy link
Member

dosaboy commented May 1, 2024

I think I have some ideas as to what is contributing to the slowness and I'm working on a solution atm. Will have something up soon.

dosaboy added a commit to dosaboy/hotsos that referenced this issue May 2, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches for a given file once.

Related-to: canonical#850
@dosaboy dosaboy self-assigned this May 2, 2024
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 2, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches for a given file once.

Related-to: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 2, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches for a given file once.

Related-to: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 3, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches for a given file once.

Related-to: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 3, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches for a given file once.

Related-to: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 3, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches for a given file once.

Related-to: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 6, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches for a given file once.

Related-to: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 6, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches for a given file once.

Related-to: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 6, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches prior to executing event callbacks so that the
results are shared with all and avoiding any repeated
searches of the same file.

Also removes some extraneous regex from some search
patterns.

Related-To: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 6, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches prior to executing event callbacks so that the
results are shared with all and avoiding any repeated
searches of the same file.

Also removes some extraneous regex from some search
patterns.

Related-To: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 7, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches prior to executing event callbacks so that the
results are shared with all and avoiding any repeated
searches of the same file.

Also removes some extraneous regex from some search
patterns.

Related-To: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 7, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches prior to executing event callbacks so that the
results are shared with all and avoiding any repeated
searches of the same file.

Also removes extraneous regex from some search patterns.

Related-To: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 8, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches prior to executing event callbacks so that the
results are shared with all and avoiding any repeated
searches of the same file.

Also removes extraneous regex from some search patterns.

Related-To: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 8, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches prior to executing event callbacks so that the
results are shared with all and avoiding any repeated
searches of the same file.

Also removes extraneous regex from some search patterns.

Related-To: canonical#850
dosaboy added a commit to dosaboy/hotsos that referenced this issue May 8, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches prior to executing event callbacks so that the
results are shared with all and avoiding any repeated
searches of the same file.

Also removes extraneous regex from some search patterns.

Related-To: canonical#850
dosaboy added a commit that referenced this issue May 8, 2024
To avoid searching the same file more than once we now
gather all searches from all events and executed all
searches prior to executing event callbacks so that the
results are shared with all and avoiding any repeated
searches of the same file.

Also removes extraneous regex from some search patterns.

Related-To: #850
@dosaboy
Copy link
Member

dosaboy commented May 13, 2024

I believe we should have a substantial improvement with some patches landed recently including the one above and also 0045208 and some recent changes to search. I have run some tests against small and large sosreports and am definitely seeing improvements. There is definitely a lot of room for improvement still, particularly around the speed of search execution and I now we have further changes queued up for that but these recent patch hopefully remove some slowness reduce memory consumption.

@dosaboy
Copy link
Member

dosaboy commented Jun 22, 2024

We now perform all event and scenario searches (per-plugin) in one go and also allow any other searches to be performed in this way. This will remove any duplicate searches or searching of long files more than once which should result in a net improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants