Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove regular expression substitution in _instance_name #100

Closed
lucabello opened this issue Apr 25, 2024 · 2 comments · Fixed by #102
Closed

remove regular expression substitution in _instance_name #100

lucabello opened this issue Apr 25, 2024 · 2 comments · Fixed by #102

Comments

@lucabello
Copy link
Contributor

Enhancement Proposal

When returning the _instance_name, we currently do a regex substitution to only keep ASCII character in label values.

However, according to the docs we link to, it explicitly mentions that label values can be unicode character.

@sabaini
Copy link

sabaini commented Apr 25, 2024

Heya, for addtl context I believe this was introduced here in the course of fixing #60

@sed-i
Copy link
Contributor

sed-i commented Apr 25, 2024

Yep, probably a confusion on my part. To summarize the doc:

  • Metric name: [a-zA-Z_:][a-zA-Z0-9_:]*
  • Label name (key): [a-zA-Z_][a-zA-Z0-9_]*
  • Label value: may contain any Unicode characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants