Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building on 24.04 #246

Open
reneradoi opened this issue Nov 6, 2024 · 2 comments
Open

Add support for building on 24.04 #246

reneradoi opened this issue Nov 6, 2024 · 2 comments

Comments

@reneradoi
Copy link

Currently it's not possible to update the base image to Ubuntu 24.04 in charmcraft.yaml because building with data-platform-workflows fails when collecting the bases. Example see draft PR in Opensearch:

collect-charm-bases --directory='.' --cache='true'
  shell: /usr/bin/bash -e {0}
Traceback (most recent call last):
  File "/opt/pipx_bin/collect-charm-bases", line 8, in <module>
    sys.exit(charm())
  File "/opt/pipx/venvs/data-platform-workflows-cli/lib/python[3](https://github.com/canonical/opensearch-operator/actions/runs/11599188033/job/32296773434?pr=495#step:5:3).10/site-packages/data_platform_workflows_cli/craft_tools/collect_bases.py", line 112, in charm
    collect(craft.Craft.CHARM)
  File "/opt/pipx/venvs/data-platform-workflows-cli/lib/python3.10/site-packages/data_platform_workflows_cli/craft_tools/collect_bases.py", line 87, in collect
    bases_ = get_bases(craft_=craft_, yaml_data=yaml_data)
  File "/opt/pipx/venvs/data-platform-workflows-cli/lib/python3.10/site-packages/data_platform_workflows_cli/craft_tools/collect_bases.py", line [4](https://github.com/canonical/opensearch-operator/actions/runs/11599188033/job/32296773434?pr=495#step:5:5)8, in get_bases
    bases = yaml_data["bases"]
KeyError: 'bases'

This is due to the breaking changes in charmcraft.yaml syntax for 24.04 (e.g. base and platforms instead of bases). Details see here: https://juju.is/docs/sdk/charmcraft-yaml#heading--bases

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/DPE-5911.

This message was autogenerated

@carlcsaposs-canonical
Copy link
Contributor

Blocked by #247

cc @taurus-forever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants