Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfg.ControlPlaneConfig.ExtraSANs not added to extra-sans array in /capi/etc/the config.yaml #93

Open
ader1990 opened this issue Jan 20, 2025 · 0 comments · May be fixed by adrian-vladu-canonical/cluster-api-k8s#1 or #95

Comments

@ader1990
Copy link

ader1990 commented Jan 20, 2025

It seems that cfg.ControlPlaneConfig.ExtraSANs, in the case of control plane, is not set in the cloud-init userdata file /capi/etc/config.yaml.

See:
https://github.com/canonical/cluster-api-k8s/blob/main/pkg/ck8s/config_init.go#L28
https://github.com/canonical/cluster-api-k8s/blob/main/pkg/ck8s/config_init.go#L126

Example CK8SControlPlane that I used:

  spec:
    spec:
      controlPlane:
        extraSANs:
        - 172.18.0.2

And the resulted /capi/etc/config.yaml:

...
# Note here that the 192.168.100.2 is the control plane VIP
# There should be another entry 172.18.0.2, with the extraSANs defined above, but only the control plane vip is present
extra-sans:
- 192.168.100.2
...

There seems to be a correct implementation for join:
https://github.com/canonical/cluster-api-k8s/blob/main/pkg/ck8s/config_join.go#L18

Maybe I am missing something here?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant