Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused seqrepo configuration #308

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

jsstevenson
Copy link
Member

close #304

I am unable to find a place where this value was even being used -- at some point, I think we must've moved it all behind Cool-Seq-Tool. I've updated the documentation to reference the Cool-Seq-Tool configuration.

@jsstevenson jsstevenson requested a review from korikuzma August 7, 2024 18:51
@jsstevenson jsstevenson added the priority:low Low priority label Aug 7, 2024
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to be updated in build_gene_suggest:

from curfu import APP_ROOT, SEQREPO_DATA_PATH, logger

@jsstevenson
Copy link
Member Author

@korikuzma my search ignores anything matching build* smh

@jsstevenson jsstevenson marked this pull request as draft August 7, 2024 19:54
@jsstevenson jsstevenson requested a review from korikuzma August 7, 2024 19:59
@jsstevenson jsstevenson marked this pull request as ready for review August 7, 2024 19:59
@jsstevenson jsstevenson removed the request for review from korikuzma August 7, 2024 19:59
@jsstevenson jsstevenson marked this pull request as draft August 7, 2024 19:59
@jsstevenson
Copy link
Member Author

Ah, dependencies won't work out here til the big PR goes through -- I'll hold off til then

@jsstevenson jsstevenson marked this pull request as ready for review August 12, 2024 16:08
@jsstevenson jsstevenson requested a review from korikuzma August 12, 2024 16:08
@jsstevenson jsstevenson merged commit 8c1fc23 into staging Aug 12, 2024
5 checks passed
@jsstevenson jsstevenson deleted the seqrepo-var branch August 12, 2024 16:18
katiestahl added a commit that referenced this pull request Oct 2, 2024
* style: update ruff and drop black (#283)

* cicd: allow missing credentials (#291)

* chore: update ebextensions for downloading latest seqrepo instance (#292)

* use 2024-02-20 SeqRepo instance

* cicd: pin exact ruff version (#297)

* refactor: address config deprecation (#299)

* feat: use latest fastapi event management api (#298)

* fix: update deprecated pytest async features (#300)

* docs: remove docstring types and clean up formatting (#301)

* fix: handle unnecessary checks for build files (#309)



Does a few things

    @korikuzma noticed that the README description of copying build files had an incorrect path. However, this instruction is actually unnecessary (and impractical tbh). In development you'd be better off letting yarn start handle service of client files because it has hot-reloading on changes. I removed it.
    Rather than requiring client files to be present, catches + logs their absence if they're not there. This is better for development. Originally I added this code in the big VRS update PR but it should've been a separate issue. I would like to see us reexamine our logging initialization/setup in another issue, because it could be bad if it's not working properly.
    Adds some additional description of why the client service code is there + what it needs.

* feat!: use latest object schemas and dependency releases (#293)

* build!: updating to vrs 2.0 models

* update pydantic-to-ts2 and update models

* wip: updating models, making variable casing consistent, converting descriptors

* fix: utilities requests

* fix: response model casing

* wip: updating models

* bug fixes

* updating models and fixing validation

* pass around formatted fusion to reduce repeated code

* fixing demo data

* specifying fusion type since null param gets dropped and fusor can't infer the type

* fixing tests and updating data with new models, bug fixes

* bug fixes for input elements

* pin latest fusor

* update dependencies

* fix clientification of demos

* fix formatting in docstrings

* fix type handling of failed lookup

* fix up gene lookup api

* fix tx utils bug

* fix bug where region and strand were incorrect in templated sequence, fix regulatory element missing field, pin pydantic version

* removing console logs

* fix: bug where error messages no longer displayed on summary page

* fixing tests and adjusting variable casing

* add reusable function for checking valid sequence locations

* add reusable function for checking valid sequence locations

* fixing nomenclature bugs

* fixing nomenclature bugs

* DOn't bother w/ semver checks (out of control of this app) and use proper fixture mode

* add assertion notes

* stash changes

* stash

* fix a few fixtures

* sequence util fixes

* minor rearrange

* fix int/str problem

* commit this

* catch static files error

* validation tests

* fix reg element URL

* remove todos

* review comments

---------

Co-authored-by: James Stevenson <[email protected]>

* cicd(fix): fix curfu path (#312)

* refactor: remove unused seqrepo configuration (#308)

* build(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /client (#276)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* revert conftest

* fix tests from merge

* update requirements

* remove debug code

* use staging requirements.txt

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: James Stevenson <[email protected]>
Co-authored-by: Kori Kuzma <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants