Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-indexed should be replaced with inter-residue when describing coordinates #324

Closed
jarbesfeld opened this issue Sep 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working priority:medium Medium priority

Comments

@jarbesfeld
Copy link
Contributor

Describe the bug

For Transcript Segment objects, when choosing genomic coordinates and transcript, the UI indicates that coordinates should be 1-indexed. However, it looks like it is taking in inter-residue coordinates.

Steps to reproduce

  1. Choose Transcript Segment, genomic coordinates and transcript
  2. For transcript, enter NM_152263.3
  3. For chromosome, enter NC_000001.11
  4. For ending position, enter 154191901

Expected behavior

N/A

Current behavior

The Transcript Segment object reported exon 1 with an offset of 0. This is correct since the coordinate corresponds to the alt_start_i value for exon 1, and the transcript is on the negative strand, so this Transcript Segment includes all of exon 1. If the coordinate was 1-indexed, there would be a nonzero offset.

Possible reason(s)

No response

Suggested fix

Indicate that supplied coordinates should be inter-residue. This will also ensure compatibility with cool-seq-tool as its methods expect inter-residue coordinates by default.

Branch, commit, and/or version

Was looking at http://fusion-curation-dev-eb.us-east-2.elasticbeanstalk.com/assayed-fusion

Screenshots

No response

Environment details

Mac M1

Additional details

No response

Contribution

None

@jarbesfeld jarbesfeld added the bug Something isn't working label Sep 4, 2024
@jsstevenson
Copy link
Member

I mean, they should be 0-indexed inter-residue, right?

@jarbesfeld
Copy link
Contributor Author

@jsstevenson Yes, but currently the UI reports that it is expects 1-indexed coordinates.
Screenshot 2024-09-04 at 12 38 12 PM

Copy link

Closed by #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants