You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The chromosome field on places like the transcript segment element builder isn't editable.
Steps to reproduce
try to make a TX segment element with gene + genomic coords
Expected behavior
It should probably be editable
For one thing, it's a text input box, it's sort of misleading that it looks editable but isn't
For another thing, this prevents users from entering anything other than the latest genomic accession (ie, one that uses GRCh38 coords). Most clinical genomics is still happening on GRCh37 -- for example, our Mayo clinic collaborators who submitted a few bugs.
Current behavior
it cant be edited
Possible reason(s)
No response
Suggested fix
For now, it's fine that we don't support GRCh37/alternate genomic accessions. I do think we should reduce the degree to which this "looks" editable but isn't, either by rendering it as text or a badge or something, or simply removing it from the interface entirely (since it's not information the user needs to edit)
In the future if we do want to support, there are a few options off the top of my head
auto populate, but leave as editable. we'd need to validate/give feedback on the content of the field
provide a dropdown with known accessions rather than a textbox
Branch, commit, and/or version
staging branch
Screenshots
No response
Environment details
n/a
Additional details
No response
Contribution
Yes, I can create a PR for this fix.
The text was updated successfully, but these errors were encountered:
in #314 I made this editable again, but I think we should reintroduce some input validation and/or make the field noneditable for when it's autopopulated or something?
Describe the bug
The chromosome field on places like the transcript segment element builder isn't editable.
Steps to reproduce
try to make a TX segment element with gene + genomic coords
Expected behavior
It should probably be editableFor another thing, this prevents users from entering anything other than the latest genomic accession (ie, one that uses GRCh38 coords). Most clinical genomics is still happening on GRCh37 -- for example, our Mayo clinic collaborators who submitted a few bugs.Current behavior
it cant be edited
Possible reason(s)
No response
Suggested fix
For now, it's fine that we don't support GRCh37/alternate genomic accessions. I do think we should reduce the degree to which this "looks" editable but isn't, either by rendering it as text or a badge or something, or simply removing it from the interface entirely (since it's not information the user needs to edit)
In the future if we do want to support, there are a few options off the top of my head
Branch, commit, and/or version
staging branch
Screenshots
No response
Environment details
n/a
Additional details
No response
Contribution
Yes, I can create a PR for this fix.
The text was updated successfully, but these errors were encountered: