From 625d2f9f91c6f4ce1ab8efb9beb791d252e41a01 Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Wed, 20 Nov 2024 16:18:38 +0500 Subject: [PATCH 01/13] fix: show focus indicators only when containers are expanded --- client/src/app/resizable-container/ResizableContainer.js | 6 +++++- client/src/app/resizable-container/ResizableContainer.less | 4 ++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/client/src/app/resizable-container/ResizableContainer.js b/client/src/app/resizable-container/ResizableContainer.js index 2a6b353319..cee7a9a8d6 100644 --- a/client/src/app/resizable-container/ResizableContainer.js +++ b/client/src/app/resizable-container/ResizableContainer.js @@ -159,7 +159,11 @@ export default function ResizableContainer(props) { ref={ ref } style={ getCSSFromProps(props) } > -
{props.children}
+
{props.children}
); diff --git a/client/src/app/resizable-container/ResizableContainer.less b/client/src/app/resizable-container/ResizableContainer.less index 21b978fff6..376670b629 100644 --- a/client/src/app/resizable-container/ResizableContainer.less +++ b/client/src/app/resizable-container/ResizableContainer.less @@ -96,4 +96,8 @@ &.open .handlebar { display: none; } + + .no-display { + display: none; + } } From bef2f5d13cec1463fe5864c31c15771d9d00d1bf Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Sun, 24 Nov 2024 16:24:27 +0500 Subject: [PATCH 02/13] fix: tab action btn --- client/src/app/tab-actions/TabActions.less | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/client/src/app/tab-actions/TabActions.less b/client/src/app/tab-actions/TabActions.less index 52aeda4655..b8e761fc4b 100644 --- a/client/src/app/tab-actions/TabActions.less +++ b/client/src/app/tab-actions/TabActions.less @@ -46,9 +46,8 @@ } } - &:focus { - outline: none; - box-shadow: none; + &:focus-visible { + outline-color: var(--focus-outline-color); } } } \ No newline at end of file From 2111d314170843ea1363efe6e119e0eb3782231f Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Mon, 25 Nov 2024 16:35:23 +0500 Subject: [PATCH 03/13] fix: bottom panel focus --- client/src/app/panel/Panel.less | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/client/src/app/panel/Panel.less b/client/src/app/panel/Panel.less index 2b4442eb17..76887358bb 100644 --- a/client/src/app/panel/Panel.less +++ b/client/src/app/panel/Panel.less @@ -25,6 +25,11 @@ border: none; outline: none; padding: 4px 8px; + + &:focus { + outline: 2px solid var(--focus-outline-color); + outline-offset: -2px; + } } .panel__link { @@ -48,6 +53,7 @@ width: 28px; height: 28px; padding: 7px; + border-radius: 50%; &:hover { background-color: var(--color-grey-225-10-85); @@ -73,6 +79,12 @@ bottom: 0; left: 0; overflow-y: auto; + margin: 1px; + } + + &:focus-visible { + outline: none; + box-shadow: inset var(--focus-shadow); } } } From fb484ebd4475956bd4c9f352157a0bd0216f3a16 Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Mon, 25 Nov 2024 19:34:26 +0500 Subject: [PATCH 04/13] fix: execution-info --- client/src/shared/ui/Section.less | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/client/src/shared/ui/Section.less b/client/src/shared/ui/Section.less index 4f8e867e7f..fc44ad5f64 100644 --- a/client/src/shared/ui/Section.less +++ b/client/src/shared/ui/Section.less @@ -40,6 +40,11 @@ .section__actions .btn { margin-top: 8px; + margin-bottom: 5px; + } + + .section__actions .btn:focus { + outline-offset: 5px; } & + :local(.Section) { From e0d85e3250d84bc461c67ac325a1b3c7b691f919 Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Mon, 25 Nov 2024 19:38:11 +0500 Subject: [PATCH 05/13] fix: version-info-hyperlinks --- client/src/shared/ui/Section.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/shared/ui/Section.less b/client/src/shared/ui/Section.less index fc44ad5f64..9818a6af33 100644 --- a/client/src/shared/ui/Section.less +++ b/client/src/shared/ui/Section.less @@ -12,7 +12,7 @@ } .section__body:not(:first-child) { - padding-top: 0px; + padding-top: 1px; } .section__header { From 8fdb2d469739900e2c20f4305a1c4de2ec6dd9ce Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Mon, 25 Nov 2024 20:51:33 +0500 Subject: [PATCH 06/13] fix: bottom tab --- client/src/app/status-bar/StatusBar.less | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/client/src/app/status-bar/StatusBar.less b/client/src/app/status-bar/StatusBar.less index d0c9bc6039..2a51d90f88 100644 --- a/client/src/app/status-bar/StatusBar.less +++ b/client/src/app/status-bar/StatusBar.less @@ -90,7 +90,10 @@ &:focus { outline: none; box-shadow: none; - background-color: var(--status-bar-focus-background-color); + } + + &:focus-visible { + box-shadow: inset var(--focus-shadow); } } From 2d72dc6fe27520bae26031909081a9400c9f5537 Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Tue, 26 Nov 2024 21:57:15 +0500 Subject: [PATCH 07/13] fix: modeler-tabs --- client/src/app/primitives/TabLinks.js | 5 +++-- client/src/app/primitives/Tabbed.less | 8 +++++++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/client/src/app/primitives/TabLinks.js b/client/src/app/primitives/TabLinks.js index 69592dd8f5..202f62ae3b 100644 --- a/client/src/app/primitives/TabLinks.js +++ b/client/src/app/primitives/TabLinks.js @@ -180,6 +180,7 @@ function Tab(props) { return (
{ @@ -253,7 +254,7 @@ function TabClose(props) { } } > - + ); } diff --git a/client/src/app/primitives/Tabbed.less b/client/src/app/primitives/Tabbed.less index df15efc7a7..d109897230 100644 --- a/client/src/app/primitives/Tabbed.less +++ b/client/src/app/primitives/Tabbed.less @@ -65,6 +65,11 @@ border-right: 1px solid var(--tab-border-right-color); user-select: none; + &:focus-visible { + outline: 2px solid var(--focus-outline-color); + outline-offset: -2px; + } + .tab__content { position: absolute; display: flex; @@ -128,11 +133,12 @@ line-height: 26px; width: 18px; height: 18px; + border: none; border-radius: 50%; background-color: var(--tab-close-background-color); .tab__icon-close { - margin: auto 0 auto -1px; + margin: auto 0 1px -1px; fill: var(--tab-close-icon-fill-color); } From 770d66f91b805027b2f3680d020f1c564c60f90e Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Tue, 26 Nov 2024 21:57:47 +0500 Subject: [PATCH 08/13] fix: focus-visible default --- client/src/styles/_base.less | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/client/src/styles/_base.less b/client/src/styles/_base.less index b5310726c6..3387330806 100644 --- a/client/src/styles/_base.less +++ b/client/src/styles/_base.less @@ -18,6 +18,10 @@ body { outline-color: var(--focus-outline-color); } +:focus-visible { + outline: 2px solid var(--focus-outline-color); +} + .djs-container svg:focus { outline: none; } From 691a7810f840382734b1399533024c5cd6567bdc Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Tue, 3 Dec 2024 20:35:04 +0500 Subject: [PATCH 09/13] fix: panel expand trigger focusable --- client/src/app/resizable-container/ResizableContainer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/app/resizable-container/ResizableContainer.js b/client/src/app/resizable-container/ResizableContainer.js index cee7a9a8d6..ddbc6777de 100644 --- a/client/src/app/resizable-container/ResizableContainer.js +++ b/client/src/app/resizable-container/ResizableContainer.js @@ -182,8 +182,8 @@ function Resizer(props) { > { isHorizontal(direction) - ? - : + ? + : }
From 993040b48e7d05224aeb850bc962daeeec0deeeb Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Tue, 3 Dec 2024 21:44:03 +0500 Subject: [PATCH 10/13] fix: watermark display --- resources/plugins/test/style.css | 4 ---- 1 file changed, 4 deletions(-) diff --git a/resources/plugins/test/style.css b/resources/plugins/test/style.css index 15702b9921..758f73147b 100644 --- a/resources/plugins/test/style.css +++ b/resources/plugins/test/style.css @@ -1,7 +1,3 @@ -.bjs-powered-by { - display: block !important; -} - .bjs-powered-by > svg { display: none; } From 3b74af369e0302090c1482cef68ff7ce2e2ae1c7 Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Mon, 9 Dec 2024 20:53:11 +0500 Subject: [PATCH 11/13] deps: update to @bpmn-io/properties-panel@3.25.1 --- client/package.json | 2 +- package-lock.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/package.json b/client/package.json index c2cbddd35b..4f3a716517 100644 --- a/client/package.json +++ b/client/package.json @@ -11,7 +11,7 @@ "@bpmn-io/dmn-migrate": "^0.5.0", "@bpmn-io/extract-process-variables": "^1.0.0", "@bpmn-io/form-js": "^1.12.0", - "@bpmn-io/properties-panel": "^3.25.0", + "@bpmn-io/properties-panel": "^3.25.1", "@bpmn-io/replace-ids": "^0.2.0", "@bpmn-io/variable-outline": "^1.0.3", "@camunda/execution-platform": "^0.3.2", diff --git a/package-lock.json b/package-lock.json index 7bbf2a6eb1..abde4e199a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -96,7 +96,7 @@ "@bpmn-io/dmn-migrate": "^0.5.0", "@bpmn-io/extract-process-variables": "^1.0.0", "@bpmn-io/form-js": "^1.12.0", - "@bpmn-io/properties-panel": "^3.25.0", + "@bpmn-io/properties-panel": "^3.25.1", "@bpmn-io/replace-ids": "^0.2.0", "@bpmn-io/variable-outline": "^1.0.3", "@camunda/execution-platform": "^0.3.2", From 9ae389eb57b398469fd2015a990851692574bc29 Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Mon, 9 Dec 2024 20:53:47 +0500 Subject: [PATCH 12/13] deps: update to @bpmn-io/variable-outline@1.0.4 --- client/package.json | 2 +- package-lock.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/package.json b/client/package.json index 4f3a716517..675d63a5ae 100644 --- a/client/package.json +++ b/client/package.json @@ -13,7 +13,7 @@ "@bpmn-io/form-js": "^1.12.0", "@bpmn-io/properties-panel": "^3.25.1", "@bpmn-io/replace-ids": "^0.2.0", - "@bpmn-io/variable-outline": "^1.0.3", + "@bpmn-io/variable-outline": "^1.0.4", "@camunda/execution-platform": "^0.3.2", "@camunda/form-linting": "^0.19.0", "@camunda/form-playground": "^0.18.0", diff --git a/package-lock.json b/package-lock.json index abde4e199a..c15eca4878 100644 --- a/package-lock.json +++ b/package-lock.json @@ -98,7 +98,7 @@ "@bpmn-io/form-js": "^1.12.0", "@bpmn-io/properties-panel": "^3.25.1", "@bpmn-io/replace-ids": "^0.2.0", - "@bpmn-io/variable-outline": "^1.0.3", + "@bpmn-io/variable-outline": "^1.0.4", "@camunda/execution-platform": "^0.3.2", "@camunda/form-linting": "^0.19.0", "@camunda/form-playground": "^0.18.0", From 21853a003d8eb95a67816933e1bbd81438baf0d4 Mon Sep 17 00:00:00 2001 From: Abdul Ahad Date: Mon, 9 Dec 2024 20:54:09 +0500 Subject: [PATCH 13/13] deps: update to camunda-bpmn-js@5.2.2 --- client/package.json | 2 +- package-lock.json | 48 ++++++++++++++++++++++----------------------- 2 files changed, 25 insertions(+), 25 deletions(-) diff --git a/client/package.json b/client/package.json index 675d63a5ae..34cbe97cfc 100644 --- a/client/package.json +++ b/client/package.json @@ -33,7 +33,7 @@ "bpmn-js-properties-panel": "^5.28.0", "bpmn-js-tracking": "^0.6.0", "bpmn-moddle": "^9.0.1", - "camunda-bpmn-js": "^5.2.1", + "camunda-bpmn-js": "^5.2.2", "camunda-bpmn-moddle": "^7.0.1", "camunda-cmmn-moddle": "^1.0.0", "camunda-dmn-js": "^3.0.0", diff --git a/package-lock.json b/package-lock.json index c15eca4878..58f21c6e0c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -118,7 +118,7 @@ "bpmn-js-properties-panel": "^5.28.0", "bpmn-js-tracking": "^0.6.0", "bpmn-moddle": "^9.0.1", - "camunda-bpmn-js": "^5.2.1", + "camunda-bpmn-js": "^5.2.2", "camunda-bpmn-moddle": "^7.0.1", "camunda-cmmn-moddle": "^1.0.0", "camunda-dmn-js": "^3.0.0", @@ -2936,9 +2936,9 @@ "integrity": "sha512-to+unsToePnm7cUeR9TrMzFlETHd/UXmU+ELTRfWZj5XGT41KF6X3L233o3E/GdEs3sk2Tbw/lOLD1avmWkg8A==" }, "node_modules/@bpmn-io/properties-panel": { - "version": "3.25.0", - "resolved": "https://registry.npmjs.org/@bpmn-io/properties-panel/-/properties-panel-3.25.0.tgz", - "integrity": "sha512-SRGgj8uJc1Yyjcht2g36Q+xKR7sTx5VZXvcwDrdmQKlx5Y3nRmvmMjDGzeGDJDb7pNU1DSlaBJic84uISDBMWg==", + "version": "3.25.1", + "resolved": "https://registry.npmjs.org/@bpmn-io/properties-panel/-/properties-panel-3.25.1.tgz", + "integrity": "sha512-DH7BynzyvpJVPQv9OpZCEqLGwNJsUkwwBb1UaLKF23uffozME1+IeO7NWvmvYVDE46vKq7h3lVYZ7uuNEO29Xg==", "license": "MIT", "dependencies": { "@bpmn-io/feel-editor": "^1.9.0", @@ -2978,9 +2978,9 @@ "license": "MIT" }, "node_modules/@bpmn-io/variable-outline": { - "version": "1.0.3", - "resolved": "https://registry.npmjs.org/@bpmn-io/variable-outline/-/variable-outline-1.0.3.tgz", - "integrity": "sha512-uVnt+vc58FDJdehhlzKVrIaNx2/NOFA8oFWExb2Nx+dTLC2upLdTXnz/SGd+EsBQ/WHzxV63j4KQ0gOzi3YhVQ==", + "version": "1.0.4", + "resolved": "https://registry.npmjs.org/@bpmn-io/variable-outline/-/variable-outline-1.0.4.tgz", + "integrity": "sha512-FDqbD75jvPswCJPYcJ1ntFUCKKza4ygV0msGFyT7WnFmgASFqv3E0BX8HStRrjMK4SdK3T+L6p9cg0EkWc5xsw==", "license": "MIT", "dependencies": { "@carbon/icons-react": "^11.43.0", @@ -12035,16 +12035,16 @@ } }, "node_modules/camunda-bpmn-js": { - "version": "5.2.1", - "resolved": "https://registry.npmjs.org/camunda-bpmn-js/-/camunda-bpmn-js-5.2.1.tgz", - "integrity": "sha512-VmvkN9aSoiihsmw3xNxLvy1uAyqT1ebussyJQt+KCl1/6PKYfs0mvWY+j2vHZp8N+aRq1BcdX2/wVFWM1AfsQQ==", + "version": "5.2.2", + "resolved": "https://registry.npmjs.org/camunda-bpmn-js/-/camunda-bpmn-js-5.2.2.tgz", + "integrity": "sha512-+s9dl+tRmmX4v4W4I7YnDFr6O/UDgvny/XFVy+n/z4SIFqdaHREnQCWM7Lpg0/23+EbgDyZQxesH8wpK7vYIuw==", "license": "MIT", "dependencies": { "@bpmn-io/align-to-origin": "^0.7.0", "@bpmn-io/element-template-chooser": "^1.0.0", "@bpmn-io/element-template-icon-renderer": "^0.5.2", "@bpmn-io/form-variable-provider": "^1.3.0", - "@bpmn-io/properties-panel": "^3.25.0", + "@bpmn-io/properties-panel": "^3.25.1", "@bpmn-io/variable-resolver": "^1.3.0", "@camunda/example-data-properties-provider": "^1.2.1", "bpmn-js": "^18.1.1", @@ -34268,9 +34268,9 @@ } }, "@bpmn-io/properties-panel": { - "version": "3.25.0", - "resolved": "https://registry.npmjs.org/@bpmn-io/properties-panel/-/properties-panel-3.25.0.tgz", - "integrity": "sha512-SRGgj8uJc1Yyjcht2g36Q+xKR7sTx5VZXvcwDrdmQKlx5Y3nRmvmMjDGzeGDJDb7pNU1DSlaBJic84uISDBMWg==", + "version": "3.25.1", + "resolved": "https://registry.npmjs.org/@bpmn-io/properties-panel/-/properties-panel-3.25.1.tgz", + "integrity": "sha512-DH7BynzyvpJVPQv9OpZCEqLGwNJsUkwwBb1UaLKF23uffozME1+IeO7NWvmvYVDE46vKq7h3lVYZ7uuNEO29Xg==", "requires": { "@bpmn-io/feel-editor": "^1.9.0", "@codemirror/view": "^6.28.1", @@ -34307,9 +34307,9 @@ "version": "0.2.0" }, "@bpmn-io/variable-outline": { - "version": "1.0.3", - "resolved": "https://registry.npmjs.org/@bpmn-io/variable-outline/-/variable-outline-1.0.3.tgz", - "integrity": "sha512-uVnt+vc58FDJdehhlzKVrIaNx2/NOFA8oFWExb2Nx+dTLC2upLdTXnz/SGd+EsBQ/WHzxV63j4KQ0gOzi3YhVQ==", + "version": "1.0.4", + "resolved": "https://registry.npmjs.org/@bpmn-io/variable-outline/-/variable-outline-1.0.4.tgz", + "integrity": "sha512-FDqbD75jvPswCJPYcJ1ntFUCKKza4ygV0msGFyT7WnFmgASFqv3E0BX8HStRrjMK4SdK3T+L6p9cg0EkWc5xsw==", "requires": { "@carbon/icons-react": "^11.43.0", "@carbon/react": "^1.59.0" @@ -40971,15 +40971,15 @@ } }, "camunda-bpmn-js": { - "version": "5.2.1", - "resolved": "https://registry.npmjs.org/camunda-bpmn-js/-/camunda-bpmn-js-5.2.1.tgz", - "integrity": "sha512-VmvkN9aSoiihsmw3xNxLvy1uAyqT1ebussyJQt+KCl1/6PKYfs0mvWY+j2vHZp8N+aRq1BcdX2/wVFWM1AfsQQ==", + "version": "5.2.2", + "resolved": "https://registry.npmjs.org/camunda-bpmn-js/-/camunda-bpmn-js-5.2.2.tgz", + "integrity": "sha512-+s9dl+tRmmX4v4W4I7YnDFr6O/UDgvny/XFVy+n/z4SIFqdaHREnQCWM7Lpg0/23+EbgDyZQxesH8wpK7vYIuw==", "requires": { "@bpmn-io/align-to-origin": "^0.7.0", "@bpmn-io/element-template-chooser": "^1.0.0", "@bpmn-io/element-template-icon-renderer": "^0.5.2", "@bpmn-io/form-variable-provider": "^1.3.0", - "@bpmn-io/properties-panel": "^3.25.0", + "@bpmn-io/properties-panel": "^3.25.1", "@bpmn-io/variable-resolver": "^1.3.0", "@camunda/example-data-properties-provider": "^1.2.1", "bpmn-js": "^18.1.1", @@ -41108,9 +41108,9 @@ "@bpmn-io/dmn-migrate": "^0.5.0", "@bpmn-io/extract-process-variables": "^1.0.0", "@bpmn-io/form-js": "^1.12.0", - "@bpmn-io/properties-panel": "^3.25.0", + "@bpmn-io/properties-panel": "^3.25.1", "@bpmn-io/replace-ids": "^0.2.0", - "@bpmn-io/variable-outline": "^1.0.3", + "@bpmn-io/variable-outline": "^1.0.4", "@camunda/execution-platform": "^0.3.2", "@camunda/form-linting": "^0.19.0", "@camunda/form-playground": "^0.18.0", @@ -41135,7 +41135,7 @@ "bpmn-js-tracking": "^0.6.0", "bpmn-moddle": "^9.0.1", "bpmnlint-loader": "^0.1.6", - "camunda-bpmn-js": "^5.2.1", + "camunda-bpmn-js": "^5.2.2", "camunda-bpmn-moddle": "^7.0.1", "camunda-cmmn-moddle": "^1.0.0", "camunda-dmn-js": "^3.0.0",