Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Editor crashes when FEEL expression is created in the File Picker form element #4644

Closed
GeethaParthasarathy opened this issue Oct 29, 2024 · 6 comments · Fixed by #4647
Labels
bug Something isn't working
Milestone

Comments

@GeethaParthasarathy
Copy link

GeethaParthasarathy commented Oct 29, 2024

Describe the bug

When we create a FEEL expression in the supported file formats field of the File Picker form element, the current form editor crashes such that it affects the subsequently created forms as well

Steps to reproduce

  1. Create a form with File picker form element
  2. Add a Feel expression to the supported file formats field and create a unparsable feel expression
  3. Correct the unparsable feel expression
  4. Even after correcting we could see the following:
    -> Feel pop up editor does not open up
    -> Form editor properties panel is frozen
    ->subsequently opened up forms are all affected
Screen.Recording.2024-10-29.at.14.39.49.mov

Expected behavior

Adding an unparsable FEEL expression to the form field should not break the form editor

Environment

  • OS: [e.g.MacOS 10.2]
  • Camunda Modeler Version: [5.29.0 rc-0]
  • Execution Platform: [ Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Oct 29, 2024
@GeethaParthasarathy
Copy link
Author

cc @camunda/hto

@vsgoulart
Copy link
Contributor

I'll check this

@vsgoulart
Copy link
Contributor

@GeethaParthasarathy I can't reproduce it. Did I do something wrong? Could check if the steps are correct?

2024-10-29.18-15-26.mp4

@GeethaParthasarathy
Copy link
Author

Hey @vsgoulart I guess there is a missed step this issue happens when there is an error in your Feel expression and then even if you rectify it the form editor is broken

Screen.Recording.2024-10-30.at.09.14.39.mov

@vsgoulart
Copy link
Contributor

@GeethaParthasarathy Here's the fix: #4647

@nikku
Copy link
Member

nikku commented Oct 30, 2024

Closed via #4647.

@nikku nikku closed this as completed Oct 30, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 30, 2024
@github-actions github-actions bot added this to the M82 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants