Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide sensible integration of Carbon into the app #4511

Open
2 tasks
nikku opened this issue Sep 9, 2024 · 7 comments
Open
2 tasks

Provide sensible integration of Carbon into the app #4511

nikku opened this issue Sep 9, 2024 · 7 comments
Assignees
Labels
ready Ready to be worked on ux

Comments

@nikku
Copy link
Member

nikku commented Sep 9, 2024

What should we do?

We want to ensure that Carbon components, such as the Variables Overview are properly integrated into the existing UI. The approach I propose is "theming", by overriding the existing Carbon variables.

  • Ensure that Carbon integrates properly into the app, without averse effects (Welcome tab changes font size #4555)
  • Consider customization so Carbon components fit into the existing UI frame

Why should we do it?

Ensure uses experience a coherent UI.

@nikku nikku added the ux label Sep 9, 2024
@nikku nikku added the ready Ready to be worked on label Sep 10, 2024
@barmac barmac added the backlog Queued in backlog label Sep 24, 2024 — with bpmn-io-tasks
@barmac barmac removed the ready Ready to be worked on label Sep 24, 2024
@barmac
Copy link
Collaborator

barmac commented Sep 24, 2024

Moving this to the backlog as we are not deriving any value from this right now. It will be useful once we introduce more Carbon components to the app.

@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Oct 15, 2024
@nikku nikku changed the title Provide sensible customization for Carbon components to fit into app UI Provide sensible integration of Carbon into the app Oct 15, 2024
@jarekdanielak
Copy link
Contributor

Related to bpmn-io/variable-outline#4 (that can possible be closed if we decide to tract this problem here)

@philippfromme
Copy link
Contributor

Moving this to backlog for now. To be picked up whenever we work on the next Carbon-heavy topic.

@philippfromme philippfromme added the backlog Queued in backlog label Oct 22, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the ready Ready to be worked on label Oct 22, 2024
@nikku
Copy link
Member Author

nikku commented Nov 21, 2024

This continues to cause issues, i.e. when integrating the improved search (#4711).

The core issue is that these styles, being inlined to variable-outline and potential other utilities are loaded async, i.e. late, and will always override ("reset") sensible defaults established elsewhere.

To go carbon first I suggest the following strategy:

  • We incorporate a recent version of the Carbon styles, as a foundation.
  • Libraries that build on top of Carbon, i.e. variable-outline do not ship the styles, but rely on them to be provided through infrastructure

This way we accomplish the following:

  • Application can do sensible adjustments ("theming") as it sees fit
  • Application has the styles there per default, hence we prevent any sort of surprises when including carbonized components
  • Such core styles should follow the ("there can only be one") philosophy, as all other framework styles (diagram-js.css, ...) follow in the editor.

@nikku
Copy link
Member Author

nikku commented Nov 28, 2024

Discussed with @marstamm today that the approach sketched earlier would work for plug-in development, too:

  • plug-ins, like any components would assume the presence of Carbon styles as "shared infrastructure", there can only be one anyway.
  • they can in whatever way inject their custom styles (lazy load and inject or provide as custom CSS that must be added to the application)
    • Custom styles MUST NOT cause side-effects
    • Custom styles MUST NOT transitively load carbon styles, but override / customize using standard means of CSS

@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Nov 28, 2024
@nikku
Copy link
Member Author

nikku commented Nov 28, 2024

Moving to ready as I think we can (and should) make substantial progress on this issue before increasing our use of Carbon.

@jarekdanielak
Copy link
Contributor

I will work on this as a part of Hackathon 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready to be worked on ux
Projects
None yet
Development

No branches or pull requests

5 participants