Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate bindingType property (supported in Camunda 8.6+) #4386

Closed
jfriedenstab opened this issue Jun 19, 2024 · 11 comments · Fixed by #4439
Closed

Validate bindingType property (supported in Camunda 8.6+) #4386

jfriedenstab opened this issue Jun 19, 2024 · 11 comments · Fixed by #4439
Assignees
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request linting
Milestone

Comments

@jfriedenstab
Copy link

jfriedenstab commented Jun 19, 2024

Problem you would like to solve

The new binding type deployment will only be supported by Zeebe 8.6 or newer. Users should be warned if they're using the new binding type in their BPMN process, but have selected a lower execution platform version.

Proposed solution

Add a new linting rule that warns the user if the binding type selected for a called process, called decision or linked form is not yet supported by the current execution platform version, for example:
A <Call Activity> with <Binding: Deployment> is only supported by Camunda 8.6 or newer

Alternatives considered

none

Additional context

@jfriedenstab jfriedenstab added enhancement New feature or request Camunda 8 Flags an issue as related to Camunda 8 linting labels Jun 19, 2024
@nikku nikku added this to the 8.6 milestone Jun 20, 2024
@nikku nikku changed the title Add linting rule for new binding type property Validate bindingType property (supported in Camunda 8.6+) Jun 20, 2024
@nikku nikku added the backlog Queued in backlog label Jun 20, 2024
@wollefitz
Copy link
Member

Update July 24

@jfriedenstab to clarify status of this issue / if it will make it before the 8.6-alpha4 release

@barmac
Copy link
Collaborator

barmac commented Aug 1, 2024

I see that this is not implemented yet, so it's not coming as part of 8.6-alpha.4. I think it's quite unfortunate that the users can already use the new property, but are left in the dark about the support of the feature.

@barmac
Copy link
Collaborator

barmac commented Aug 1, 2024

I'm moving this to ready.

@barmac barmac added ready Ready to be worked on and removed backlog Queued in backlog labels Aug 1, 2024
@barmac
Copy link
Collaborator

barmac commented Aug 1, 2024

Assigning @philippfromme as the assignee of #4385. Feel free to drop it if you don't have capacity.

@jfriedenstab
Copy link
Author

Thanks, @barmac! Is there any chance that this could be implemented in the next days, @philippfromme? Then we could still try to include it in the release.

@philippfromme
Copy link
Contributor

@jfriedenstab I'm on it!

@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Aug 1, 2024
@jfriedenstab
Copy link
Author

Great, thank you! 🙂

philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Aug 1, 2024
@philippfromme
Copy link
Contributor

philippfromme commented Aug 1, 2024

Pull requests incoming:

philippfromme added a commit to camunda/linting that referenced this issue Aug 1, 2024
philippfromme added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Aug 1, 2024
@barmac
Copy link
Collaborator

barmac commented Aug 1, 2024

In that case, we may also include it in #4439

philippfromme added a commit to camunda/linting that referenced this issue Aug 1, 2024
@philippfromme
Copy link
Contributor

In that case, we may also include it in #4439

Yes, I'd like that.

philippfromme added a commit to camunda/linting that referenced this issue Aug 1, 2024
barmac added a commit that referenced this issue Aug 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 1, 2024
@barmac barmac closed this as completed in cda7aef Aug 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 1, 2024
@barmac barmac modified the milestones: 8.6, M79 Aug 1, 2024
@barmac
Copy link
Collaborator

barmac commented Aug 1, 2024

I've updated the milestone since this is shipped with the current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request linting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants