Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessible names to the XML/JSON editors #4370

Closed
barmac opened this issue Jun 14, 2024 · 3 comments · Fixed by #4379
Closed

Add accessible names to the XML/JSON editors #4370

barmac opened this issue Jun 14, 2024 · 3 comments · Fixed by #4379
Assignees
@barmac
Labels
a11y
Milestone
M78

Comments

@barmac
Copy link
Collaborator

barmac commented Jun 14, 2024 •
edited by nikku
Loading

What should we do?

Add accessible names to the XML/JSON editors

Why should we do it?

Child of https://github.com/bpmn-io/internal-docs/issues/909
@barmac barmac added ready Ready to be worked on a11y labels Jun 14, 2024
@barmac
Copy link
Collaborator Author

barmac commented Jun 18, 2024

An additional error is reported in the editors:

image

It is present on the codemirror website as well: https://codemirror.net/

barmac added a commit that referenced this issue Jun 18, 2024
@barmac
fix: add accessible names to code editors
81f8a51 
Closes #4370
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 18, 2024
@barmac barmac mentioned this issue Jun 18, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 18, 2024
barmac added a commit that referenced this issue Jun 18, 2024
@barmac
fix: add accessible names to code editors
7c8be36 
Closes #4370
@nikku
Copy link
Member

nikku commented Jun 19, 2024 •
edited
Loading

#4370 (comment)

This is a false-positive; code mirror editor is absolutely focusable via keyboard. If possible, let's black list this violation.

@nikku
Copy link
Member

nikku commented Jun 19, 2024

Closed via #4379.

@nikku nikku closed this as completed Jun 19, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 19, 2024
@nikku nikku added this to the M78 milestone Jun 19, 2024
@nikku nikku added needs review Review pending and removed needs review Review pending labels Jun 19, 2024
@marstamm marstamm mentioned this issue Jun 19, 2024
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
a11y
Projects
None yet
Milestone
M78
Development

Successfully merging a pull request may close this issue.

Add accessible names and tabindex to code editors camunda/camunda-modeler
2 participants
@nikku @barmac