Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boundary event attachment for compensation activity allowed via new context pad #4348

Closed
barmac opened this issue Jun 6, 2024 · 0 comments · Fixed by #4381
Closed

Boundary event attachment for compensation activity allowed via new context pad #4348

barmac opened this issue Jun 6, 2024 · 0 comments · Fixed by #4381
Assignees
@philippfromme @marstamm
Labels
bug Something isn't working
Milestone
M78

Comments

@barmac
Copy link
Collaborator

barmac commented Jun 6, 2024 •
edited by nikku
Loading

Describe the bug

image

Compensation activities cannot have boundary events, yet I can attach it via the new context pad.

Steps to reproduce

  1. Create a compensation activity
  2. Highlight bottom "+" and select an event
  3. now this happens

Expected behavior

There should be either no icon at all, or a selection should make the activity non-compensation again.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: 5.24.0
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: enabled new context pad

Additional context

No response

Depends on camunda/improved-canvas#68
@barmac barmac added the bug Something isn't working label Jun 6, 2024
@barmac barmac mentioned this issue Jun 6, 2024
Closed
39 tasks
philippfromme added a commit to camunda/improved-canvas that referenced this issue Jun 7, 2024
@philippfromme
fix(attach-create-pad): do not show for compensation activities
19aced5 
Related to camunda/camunda-modeler#4348
@philippfromme philippfromme mentioned this issue Jun 7, 2024
Merged
@nikku nikku added the in progress Currently worked on label Jun 7, 2024 — with bpmn-io-tasks
@nikku nikku added the fixed upstream Requires integration of upstream change label Jun 7, 2024 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Jun 7, 2024
@marstamm marstamm added this to the M78 milestone Jun 17, 2024
philippfromme added a commit to camunda/improved-canvas that referenced this issue Jun 18, 2024
@philippfromme
fix(attach-create-pad): do not show for compensation activities
0e1aa08 
Related to camunda/camunda-modeler#4348
marstamm added a commit that referenced this issue Jun 19, 2024
@marstamm
deps: bump modeling dependencies
8dde190 
closes #4319
closes #4348
@marstamm marstamm mentioned this issue Jun 19, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jun 19, 2024
marstamm added a commit that referenced this issue Jun 19, 2024
@marstamm
deps: bump modeling dependencies
9671312 
closes #4319
closes #4348
@marstamm marstamm mentioned this issue Jun 19, 2024
Closed
38 tasks
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

@marstamm marstamm

Labels
bug Something isn't working
Projects
None yet
Milestone
M78
Development

Successfully merging a pull request may close this issue.

Release: bump dependencies camunda/camunda-modeler
4 participants
@nikku @philippfromme @marstamm @barmac