Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ID must not be empty" is not displayed in DMN editor #4319

Closed
barmac opened this issue May 28, 2024 · 1 comment · Fixed by #4381
Closed

"ID must not be empty" is not displayed in DMN editor #4319

barmac opened this issue May 28, 2024 · 1 comment · Fixed by #4381
Assignees
@marstamm @barmac
Labels
bug Something isn't working DMN properties panel
Milestone
M78

Comments

@barmac
Copy link
Collaborator

barmac commented May 28, 2024 •
edited by nikku
Loading

Describe the bug

In 5.20.0, the Modeler stopped to display the ID validation error in the DMN editor:

image

Compare that to 5.19.0:

image

Steps to reproduce

  1. Open DMN editor
  2. Erase the ID
  3. now this happens

Expected behavior

The error is still displayed.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: 5.20.0 and later
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

Depends on bpmn-io/dmn-js-properties-panel#85
@barmac barmac added bug Something isn't working ready Ready to be worked on DMN properties panel labels May 28, 2024
@barmac barmac mentioned this issue May 28, 2024
Merged
@nikku
Copy link
Member

nikku commented May 28, 2024

Linked to upstream bug report - bpmn-io/dmn-js-properties-panel#85.

@barmac barmac added the fixed upstream Requires integration of upstream change label Jun 11, 2024 — with bpmn-io-tasks
@barmac barmac removed the ready Ready to be worked on label Jun 11, 2024
@marstamm marstamm added this to the M78 milestone Jun 17, 2024
marstamm added a commit that referenced this issue Jun 19, 2024
@marstamm
deps: bump modeling dependencies
8dde190 
closes #4319
closes #4348
@marstamm marstamm mentioned this issue Jun 19, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jun 19, 2024
marstamm added a commit that referenced this issue Jun 19, 2024
@marstamm
deps: bump modeling dependencies
9671312 
closes #4319
closes #4348
marstamm added a commit that referenced this issue Jun 19, 2024
@marstamm
deps: bump modeling dependencies
dacc086 
closes #4319
closes #4348
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

@barmac barmac

Labels
bug Something isn't working DMN properties panel
Projects
None yet
Milestone
M78
Development

Successfully merging a pull request may close this issue.

Release: bump dependencies camunda/camunda-modeler
3 participants
@nikku @marstamm @barmac