Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OAuth scope field to deploy modal #4102

Closed
wollefitz opened this issue Feb 5, 2024 · 10 comments · Fixed by #4169
Closed

Add OAuth scope field to deploy modal #4102

wollefitz opened this issue Feb 5, 2024 · 10 comments · Fixed by #4169
Assignees
@nikku
Labels
Camunda 8 Flags an issue as related to Camunda 8 deploy enhancement New feature or request
Milestone
M74

Comments

@wollefitz
Copy link
Member

wollefitz commented Feb 5, 2024 •
edited by nikku
Loading

Related to https://github.com/camunda/product-hub/issues/2089.

Problem you would like to solve

As a user, I want to be able to deploy to Zeebe clusters that use OAuth2 as authentication mechanism with a provider that requires a scope in the token request, e.g. Microsoft Entra ID.

Proposed solution

Add a field "Scope" (or better "OAuth Scope" and rename "Audience" to "OAuth Audience") to the deploy modal which gets picked up by the Zeebe client for acquiring a token.

Alternatives considered

None

Additional context

Depends on camunda-community-hub/zeebe-client-node-js#363
@wollefitz wollefitz added enhancement New feature or request deploy ready Ready to be worked on labels Feb 5, 2024
@wollefitz wollefitz mentioned this issue Feb 5, 2024
Closed
@nikku nikku added the blocked label Feb 6, 2024
@nikku
Copy link
Member

nikku commented Feb 6, 2024

We'd need zeebe-node to support passing a custom scope within the token request and this seems to be not implemented (yet). So as it stands we're currently blocked by upstream here I believe?

Shall I create an upstream issue @jwulf?

@nikku
Copy link
Member

nikku commented Feb 6, 2024 •
edited
Loading

@wollefitz Thanks for opening this issue! I buy into both the enhancement + proposed renaming.

@wollefitz
Copy link
Member Author

Shall I create an upstream issue @jwulf?

@nikku There's already camunda/camunda-8-js-sdk#21 (linked below "Additional Contect") created by Josh.

@nikku
Copy link
Member

nikku commented Feb 6, 2024

Thanks @wollefitz. I'm a little bit confused as I don't care about camunda-8-js-sdk. We use the zeebe-node client and have not immediate intention to move to something else, unless explicitly required to do so.

@nikku nikku self-assigned this Feb 6, 2024
@jwulf
Copy link
Member

jwulf commented Feb 7, 2024

@nikku - with the 8.5.0 release we will be supporting the JS SDK.

The Zeebe Node client published as zeebe-node is going to be unmaintained from 8.5.0.

The new package will be @camunda8/zeebe. It’s the same code base, but moved to the camunda-8-js-sdk monorepo.

@nikku
Copy link
Member

nikku commented Feb 7, 2024

Thanks for the heads-up @jwulf.

@nikku nikku mentioned this issue Feb 7, 2024
Open
@nikku
Copy link
Member

nikku commented Feb 7, 2024

Created #4109 from our end. Would be great to get a heads-up when @camunda8/zeebe is ready to be migrated to.

It would help us if we'd get scope support in one way or the other, so we can integrate it into the modeler.

@nikku nikku added this to the 8.5 milestone Feb 7, 2024
@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Feb 7, 2024
@nikku nikku added the ready Ready to be worked on label Feb 23, 2024 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Feb 23, 2024
nikku added a commit to nikku/zeebe-client-node-js that referenced this issue Feb 29, 2024
@nikku
feat: support configuration of OAuth scope
7fb01c9 
Related to camunda/camunda-modeler#4102

Implements camunda/camunda-8-js-sdk#21
nikku added a commit to nikku/zeebe-client-node-js that referenced this issue Feb 29, 2024
@nikku
feat: support configuration of OAuth scope
68c3bad 
Related to camunda/camunda-modeler#4102

Implements camunda/camunda-8-js-sdk#21
@nikku nikku mentioned this issue Feb 29, 2024
Merged
@nikku
Copy link
Member

nikku commented Feb 29, 2024

Waiting for upstream camunda-community-hub/zeebe-client-node-js#363 to be merged and released.

jwulf added a commit to camunda-community-hub/zeebe-client-node-js that referenced this issue Mar 1, 2024
@nikku @jwulf
Oauth scope (#363)
4ba4882 
* feat: support configuration of OAuth `scope`

Related to camunda/camunda-modeler#4102

Implements camunda/camunda-8-js-sdk#21

* chore(types): `ZClientOptions#hostname` can be null

Returned internally as `null`.

* test: rewrite test cleanup

Ensures we properly clean up after each test,
also in cases of test failures.

* Small tweaks

* update CHANGELOG

---------

Co-authored-by: Josh Wulf <[email protected]>
nikku added a commit that referenced this issue Mar 1, 2024
@nikku
deps: update to [email protected]
7216740 
Provides the foundations for #4102
@nikku nikku mentioned this issue Mar 1, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Mar 1, 2024
@nikku
Copy link
Member

nikku commented Mar 1, 2024

Continuing to integrate this via #4169.

@nikku nikku removed this from the 8.5 milestone Mar 1, 2024
@nikku nikku added this to the M74 milestone Mar 1, 2024
@nikku nikku removed the blocked label Mar 1, 2024
nikku added a commit that referenced this issue Mar 1, 2024
@nikku
feat: support OAuth scope
519764b 
* Rename `Audience` to `OAuth audience`
* Add `OAuth scope` field

Closes #4102
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 1, 2024
nikku added a commit that referenced this issue Mar 4, 2024
@nikku
deps: update to [email protected]
93b482b 
Provides the foundations for #4102
nikku added a commit that referenced this issue Mar 4, 2024
@nikku
feat: support OAuth scope
0150535 
* Rename `Audience` to `OAuth audience`
* Add `OAuth scope` field

Closes #4102
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 4, 2024
@nikku
Copy link
Member

nikku commented Mar 4, 2024

This will be released with the next Desktop Modeler release (v5.21.0).

@nikku nikku added the Camunda 8 Flags an issue as related to Camunda 8 label Mar 5, 2024
@nikku nikku mentioned this issue Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
Camunda 8 Flags an issue as related to Camunda 8 deploy enhancement New feature or request
Projects
None yet
Milestone
M74
Development

Successfully merging a pull request may close this issue.

Support scope when configuring OAuth details camunda/camunda-modeler
3 participants
@nikku @jwulf @wollefitz