get or else Camunda FEEL function is marked as syntax error

[barmac]

Describe the bug

When I choose get or else function from the suggestions, it's marked as syntax error.

Screen.Recording.2023-11-14.at.10.32.47.mov

Steps to reproduce

1. Start writing get or and notice the suggestion
2. Hit enter
3. now this happens

Expected behavior

The expression get or else(variable, defaultValue) should be parsed as:

Expression [0, 35]
  FunctionInvocation [0, 35]
    VariableName [0, 11]
    PositionalParameters [12, 34]
      VariableName [12, 20]
      VariableName [22, 34]

This must be tuned in two places:

• Syntax is aware of Camunda extensions (Rewrite bpmn-io/feel-editor#56)
• Linting is aware of Camunda extensions (Configurable language parsing bpmn-io/feel-lint#23)

Environment

• OS: [e.g. MacOS 10.2, Windows 10]
• Camunda Modeler Version: [e.g. 2.0.0]
• Execution Platform: [e.g. Camunda 7, Camunda 8]
• Installed plug-ins: [...]

Additional context

The built-in extension function should be provided in the context because it uses keywords.

SUPPORT-19273
SUPPORT-23453
SUPPORT-23592

[marstamm]

We could add a quick-fix and add it to the expression context, but that would not solve the underlying issue. We are currently supporting two FEEL engines with different capabilities, but use the same editor tooling for both.

Cf. @nikku comment on Slack: https://camunda.slack.com/archives/GP70M0J6M/p1699970314078889?thread_ts=1699954926.982759&cid=GP70M0J6M

We should try to solve it on the language level. In the long term, we need a decision on how to handle extensions, especially when we want to add a FEEL playground in the modeler experience at one point.

[JeromeiMSA]

Hi,

The same problem occurs with Camunda Modeler 5.18.0 :

But, we can deploy the BPMN diagram on platform 8.3. And the process works correctly.

[barmac]

This has been independently reported by multiple users.

[nikku]

Moving to backlog.

[nikku]

Let's investigate if this is an easy pick.

[nikku]

Did not make it into the M76 milestone.

[nikku]

I looked into this yesterday and found that there is sensible improvements we could make in the feel-editor:

• Any declared built-in shall also be available for syntax completion
• We can make better use of the batteries included in code mirror for retrieving available variables and built-ins.
• To be considered: Built-ins are a domain, not a library concern; consider to offer the core as part of the library, but make it extensible, i.e. with Camunda built-ins.

[nikku]

@barmac Assigning myself as I'll look into this post release (I have the context still).

[nikku]

Updating the feel-editor unfortunately does not solve the issue:

What I missed is that we'd also need to update our FEEL validation to recognize the get or else built-in.

[nloding]

Adding another user report so priority can be adjusted as needed: https://forum.camunda.io/t/unparsable-feel-expression-is-it-a-bug-in-modeler/53862/

[nikku]

Thanks. A fix is already work in progress.

[valeriaportolesicamunda]

Another customer has reported this: SUPPORT-23453

[rtkohl]

Another customer has reported this: SUPPORT-23592.
is there any workaround for this or an estimated date on when this will be fixed? My customer is using 8.5

[nikku]

We're currently working on supporting this; customers will need to simply upgrade their modelers to the latest version, and may continue to use 8.5 (run-time) to benefit from a fix.

[Eilenn]

Any updates?