Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to extend context pad and palette for Camunda Cloud #87

Open
nikku opened this issue Jan 25, 2022 · 3 comments
Open

Impossible to extend context pad and palette for Camunda Cloud #87

nikku opened this issue Jan 25, 2022 · 3 comments
Labels
backlog Queued in backlog bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@nikku
Copy link
Member

nikku commented Jan 25, 2022

Describe the Bug

As a user I'd love to extend the camunda-bpmn-js Camunda Cloud distribution in the same way I'm used to extend bpmn-js (core).

However, I've stumbled over the fact that we do filter context pad entries based on a whitelist (rather than a black list), cf. https://github.com/camunda/camunda-bpmn-js/search?q=availableActions.

This essentially makes it impossible to provide custom context pad entries to the modeler.

Steps to Reproduce

  1. Bootstrap camunda-bpmn-js with a custom context pad/palette provider
  2. See that context pad / palette entries are being removed / filtered out

Expected Behavior

If we filter we should filter based on a blacklist, not whitelist.

Alternatively, we should filter entries with normal, not low priority to allow adding additional extensions after filtering took place.

To work around this issue I need to register my providers with even lower priority; that does sound like a short term hack to me, rather than a proper solution.

Environment

  • OS: Any
  • Modeler version: latest
@nikku nikku added the bug Something isn't working label Jan 25, 2022
@barmac
Copy link
Contributor

barmac commented Jan 26, 2022

But you can have a context pad provider with a lower priority though :)

@nikku
Copy link
Member Author

nikku commented Jan 26, 2022

You can, you just have to read the source code to figure this out (i.e. at which priority to hook into) 😉

@MaxTru MaxTru added the ready Ready to be worked on label Jan 26, 2022
@MaxTru MaxTru added the backlog Queued in backlog label Mar 25, 2022 — with bpmn-io-tasks
@MaxTru MaxTru removed the ready Ready to be worked on label Mar 25, 2022
@nikku
Copy link
Member Author

nikku commented Apr 7, 2022

We fell for this one, again 🎉.

@nikku nikku removed their assignment May 25, 2022
@nikku nikku added the spring cleaning Could be cleaned up one day label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

3 participants