Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Spring Boot 3.4 #4657

Open
3 of 4 tasks
toco-cam opened this issue Sep 25, 2024 · 4 comments
Open
3 of 4 tasks

Support Spring Boot 3.4 #4657

toco-cam opened this issue Sep 25, 2024 · 4 comments
Assignees
Labels
potential:7.22.2 type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.23.0

Comments

@toco-cam
Copy link
Member

toco-cam commented Sep 25, 2024

Acceptance Criteria (Required on creation)

Hints

Is planned to be released November 21, 2024.

Links

Breakdown

Pull Requests

  1. bot:backport:7.22 bot:java-dependency-check ci:all-as ci:e2e ci:run ci:spring-boot
    mboskamp
  2. mboskamp
  3. mboskamp

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@toco-cam toco-cam added the type:task Issues that are a change to the project that is neither a feature nor a bug fix. label Sep 25, 2024
@tasso94 tasso94 changed the title Support SpringBoot 3.4 Support Spring Boot 3.4 Sep 25, 2024
@mboskamp
Copy link
Member

FYI 3.4.0-RC1 was released

@mboskamp mboskamp self-assigned this Nov 15, 2024
mboskamp added a commit that referenced this issue Nov 18, 2024
@tasso94
Copy link
Member

tasso94 commented Nov 18, 2024

This might be related #4753

mboskamp added a commit that referenced this issue Dec 3, 2024
mboskamp added a commit that referenced this issue Dec 5, 2024
mboskamp added a commit that referenced this issue Dec 5, 2024
mboskamp added a commit that referenced this issue Dec 5, 2024
mboskamp added a commit that referenced this issue Dec 5, 2024
@mboskamp
Copy link
Member

mboskamp commented Dec 6, 2024

Findings

Spring Boot 3.4.0 release notes

The official release notes are published here.

RestClient and RestTemplate

We use the RestTemplate for testing in Camunda Run. The changes highlighted in the release notes impact how redirects are handled. Without any further configuration, the underlying HttpClient will follow redirects from HTTP to HTTPS. This broke one test that tests HTTP(S) configurations in Camunda Run. spring.http.client.factory: simple needs to be configured for the RestTemplate to behave as before 3.4.0.

Another change in the RestTemplate's underlying HttpClient caused a different error message to be returned when sending an HTTP request to an HTTPS endpoint for Camunda Run. The error message needed to be updated in the test. The new error message is backward compatible (works as well for Spring Boot 3.3.x).

Removal of deprecations

Spring Boot 3.4.0 removes classes marked as deprecated in 3.3.x (source). This had no effect on our code.

Startup issues

The httpclient5 had to be updated to the version specified for Spring Boot 3.4.0. Otherwise, the Spring Boot Starter would not start.

mboskamp added a commit to camunda/camunda-docs-manual that referenced this issue Dec 6, 2024
mboskamp added a commit to camunda/camunda-docs-manual that referenced this issue Dec 6, 2024
mboskamp added a commit to camunda/camunda-docs-manual that referenced this issue Dec 6, 2024
@mboskamp mboskamp assigned joaquinfelici and unassigned mboskamp Dec 6, 2024
mboskamp added a commit that referenced this issue Dec 9, 2024
mboskamp added a commit to camunda/camunda-docs-manual that referenced this issue Dec 9, 2024
mboskamp added a commit to camunda/camunda-docs-manual that referenced this issue Dec 9, 2024
@mboskamp
Copy link
Member

I reverted the commit to master (69958d3) due to test failures.

[2024-12-10T12:18:36.924Z] [ERROR] testHttpBasicAuthenticationCheck[0](org.camunda.bpm.engine.rest.standalone.AuthenticationFilterPathMatchingTest)  Time elapsed: 0.032 s  <<< ERROR!

[2024-12-10T12:18:36.925Z] java.lang.NoClassDefFoundError: org/springframework/http/MediaType

[2024-12-10T12:18:36.925Z] 	at org.camunda.bpm.engine.rest.standalone.AuthenticationFilterPathMatchingTest.testHttpBasicAuthenticationCheck(AuthenticationFilterPathMatchingTest.java:200)

[2024-12-10T12:18:36.925Z] Caused by: java.lang.ClassNotFoundException: org.springframework.http.MediaType

[2024-12-10T12:18:36.925Z] 	at org.camunda.bpm.engine.rest.standalone.AuthenticationFilterPathMatchingTest.testHttpBasicAuthenticationCheck(AuthenticationFilterPathMatchingTest.java:200)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential:7.22.2 type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.23.0
Projects
None yet
Development

No branches or pull requests

4 participants