Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to upload file to database on heroku website #79

Open
snlongmore opened this issue May 26, 2015 · 22 comments
Open

Failed to upload file to database on heroku website #79

snlongmore opened this issue May 26, 2015 · 22 comments

Comments

@snlongmore
Copy link
Contributor

Tried to upload a file with the following text to the heroku website:

name,ID,R[pc],V[km/s],SurfDens[Msun/pc^2]

MarkSwinbank,1,110.,45.,1.0e+04
MarkSwinbank,2,116.,82.,2.2e+04
MarkSwinbank,3,105.,63.,4.0e+04
MarkSwinbank,4,160.,74.,2.8e+04
MarkSwinbank,5,300.,56.,8.6e+03

Here is the text I entered:

screen shot 2015-05-26 at 10 13 15

I get the standard "The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.” error message when I hit submit.

@keflavich
Copy link
Contributor

@snlongmore if you open the "Inspector" using chrome, safari, or firefox, and you look at the Javascript console (I can help you find this if needed), do you see errors popping up?

Does the latest version work with camelot-project/frontend#96 included?

(also, I was wrong, this is a frontend issue, not a database issue)

@jmdkastro
Copy link
Contributor

@snlongmore Maybe the server didn't like the reference ;) ...shouldn't it be http://adsabs.harvard.edu/abs/2011ApJ...742...11S?

@snlongmore
Copy link
Contributor Author

@jmdkastro very true! Good spot. Clearly there is no way to get around user error here. Perhaps a function to automatically recognise the paper from the data...just kidding @keflavich!

@snlongmore
Copy link
Contributor Author

Sorry @keflavich but I broke it again. Tried to upload snl_bolatto_08.csv and got the same error again. Here is the screen shot of the input

screen shot 2015-05-26 at 16 35 09

@snlongmore
Copy link
Contributor Author

Weird!!! When I go to the Heroku website and try to query the database it says the Bolatto data is there... is this related to my above issue??

@agianne
Copy link
Contributor

agianne commented May 29, 2015

Similar problem here. I tried to upload my dataset and it told me that there was no difference with the current version of the database, but on query it shows my dataset as well!

@keflavich
Copy link
Contributor

@agianne - that means your data set was already included in the database, I think?

@agianne
Copy link
Contributor

agianne commented May 29, 2015

@keflavich It would seem so. However I checked the query page before submitting and it was not there. I don't understand what's happened there

@keflavich
Copy link
Contributor

Neither do I. Something is wrong with the database on the heroku server. I'll investigate.

@keflavich
Copy link
Contributor

@agianne I think it is probably fixed now. Could you give it a try in >2 minutes?

@agianne
Copy link
Contributor

agianne commented May 29, 2015

Tested again. I did not enter the ADS ID, but just the DOI and I got an internal server error. The data set was uploaded anyway.

@keflavich
Copy link
Contributor

could you save your upload form and take a screenshot?

Your database was not successfully uploaded - there is no new pull request.

@agianne
Copy link
Contributor

agianne commented May 29, 2015

I noticed - but I see my data in the query!
2015-05-29-123214_1280x1024_scrot
This is the error I get:
2015-05-29-123345_1280x1024_scrot
and finally the query results:
2015-05-29-123551_1280x1024_scrot

@keflavich
Copy link
Contributor

I think this means that the cleanup stage failed, which is very bad.

@keflavich
Copy link
Contributor

@agianne I'm deploying another attempt at a solution. I still don't understand what's causing your underlying problem, but I should have cured enough of the symptoms to now see past them.

@agianne
Copy link
Contributor

agianne commented May 29, 2015

@keflavich same error. At least I don't see my dataset in the query!
2015-05-29-144233_1280x1024_scrot

@keflavich
Copy link
Contributor

The problem seems to be that the table did not read correctly. However, I can't reproduce your error; I get:

There has been a server-side error:
The value must be a valid Python or Numpy numeric type.
Traceback (most recent call last): File "upload_form.py", line 306, in set_columns convert_units(table) File "/Users/adam/repos/camelot_frontend/ingest_datasets_better.py", line 93, in convert_units tbl[k] = tbl[k].to(v) File "/Users/adam/repos/astropy/astropy/table/column.py", line 688, in to return self.quantity.to(unit, equivalencies) File "/Users/adam/repos/astropy/astropy/table/column.py", line 666, in quantity return Quantity(self, copy=False, dtype=self.dtype, order='A') File "/Users/adam/repos/astropy/astropy/units/quantity.py", line 243, in __new__ raise TypeError("The value must be a valid Python or " TypeError: The value must be a valid Python or Numpy numeric type.

@agianne
Copy link
Contributor

agianne commented May 29, 2015

Try to remove the header line with the units (camelot-project/frontend#45)

@e-koch
Copy link
Contributor

e-koch commented May 31, 2015

I'm also getting the same error as @agianne.

@e-koch
Copy link
Contributor

e-koch commented May 31, 2015

Can confirm that frontend #104 appears to fix this issue.

@snlongmore
Copy link
Contributor Author

So I just tried to upload a file to the database for Lisa Wei's data and got the following error

screen shot 2015-06-09 at 10 13 19

I checked and found there was actually still a PR #82 for that data set from when I tried a few weeks ago, so I thought this might explain the error. However, I then checked closely and see I left a space between the first and last name, i.e. "Lisa Wei" instead of "LisaWei". I then repeated the upload removing the space and it seems to have worked fine. This rules out the previous attempt at submitting this data set from causing the problem. If it is the "space" problem, I suspect this may be a common mistake. It would be good to (i) add a warning message about this on the upload page, (ii) not let the person submit if there is a whitespace in the name field.

@snlongmore
Copy link
Contributor Author

I just tried to upload Mark Heyer's data with these parameters

screen shot 2015-06-09 at 11 09 59

and got the following error:

screen shot 2015-06-09 at 11 08 22

Not sure what went wrong there -- I can't see anything obviously stupid with the values I put in...

A PR was not created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants