Theme Act

[HeshamHassan]

In all pages:

• Fix the jump that happened to the header when scrolling down and up.
• Remove the white space under the header.

[mohamedMahdyCc]

@HeshamHassan , can you please descripe more info about the issue you mean in all cms/pages , or on all website pages ?

[mohamedMahdyCc]

@HeshamHassan Remove the white space under the header. Done!

[HeshamHassan]

@mohamedMahdyCc
All website pages

@HeshamHassan , can you please descripe more info about the issue you mean in all cms/pages , or on all website pages ?

[mohamedMahdyCc]

@ahmedelbougha @HeshamHassan
about the header jump when scroll down, this behavior normal and already exist with the original theme source code, kindly you can download new version from it if you want and we can integrate

about page gabs Done! please confirm and close

[HeshamHassan]

• Remove the white space under the header : Done

[HeshamHassan]

• Fix the jump that happened to the header when scrolling down and up.

@Ali-Galal : Kindly advice

[mohamedMahdyCc]

@HeshamHassan
As user when scroll down i need to keep see the page title or course title

[HeshamHassan]

@mohamedMahdyCc
Need estimation for:

• Decrease the main image Hight in the home page to fit the screen on launch.

[mohamedMahdyCc]

@mohamedMahdyCc
Need estimation for:

• Decrease the main image Hight in the home page to fit the screen on launch.

i suggest to make the page title or course title sticky like the header so you will keep see the titles while scrolling down

Estimation: 2 hrs

@HeshamHassan @Ali-Galal
please confirm if this accepted to start

[Ali-Galal]

@mohamedMahdyCc
Need estimation for:

• Decrease the main image Hight in the home page to fit the screen on launch.

i suggest to make the page title or course title sticky like the header so you will keep see the titles while scrolling down

Estimation: 2 hrs

@HeshamHassan @Ali-Galal
please confirm if this accepted to start

@mohamedMahdyCc this is not what we need, I sent the clarification on the whatsapp group

[mohamedMahdyCc]

@mohamedMahdyCc
Need estimation for:

• Decrease the main image Hight in the home page to fit the screen on launch.

i suggest to make the page title or course title sticky like the header so you will keep see the titles while scrolling down
Estimation: 2 hrs
@HeshamHassan @Ali-Galal
please confirm if this accepted to start

@mohamedMahdyCc this is not what we need, I sent the clarification on the whatsapp group

@Ali-Galal thanks for info

Estimation: 5hrs

[Ali-Galal]

@ahmedelbougha I just want to decrease the image hight, the istemation is a little bit high

[Ali-Galal]

@ahmedelbougha reminder

[Ali-Galal]

2nd reminder

[mohamedMahdyCc]

@Ali-Galal Estimation: 5hrs

[Ali-Galal]

@mohamedMahdyCc approved

[Mahmoud-Ibrahim1]

@Ali-Galal @mohamedMahdyCc Done! please confirm and close

[Ali-Galal]

The Act is ok, but the image hight still the same

[MoatazAbdAlmageed]

@Ali-Galal Please try to clear the cache (or incognito mode ), If the problem still exists please send me a screenshot. @mohamedMahdyCc

[Ali-Galal]

@MoatazAbdAlmageed I did but still the same

[MoatazAbdAlmageed]

@Ali-Galal could you please provide an image like this

I think now image is reduced

[Ali-Galal]

[MoatazAbdAlmageed]

I mean screenshot contains the slider and the section underneath the slider with colored blocks

…

On Thu, Feb 7, 2019, 12:40 PM Ali-Galal ***@***.*** wrote: [image: image] <https://user-images.githubusercontent.com/36264944/52406082-e33bd900-2add-11e9-8bf8-59642e18c4d6.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#231 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQkXeiiZp6xDPnfV9nEs4LGYlX4yg5Sqks5vLAKTgaJpZM4ZWBrb> .

[Ali-Galal]

[MoatazAbdAlmageed]

@Ali-Galal Okay I will check but I'm wondering it works in my machine I will test it in another machine also

[MoatazAbdAlmageed]

@Ali-Galal pushed I will notify you after deploy to the server.

[MoatazAbdAlmageed]

@Ali-Galal Please check

[Ali-Galal]

@MoatazAbdAlmageed still the same

[MoatazAbdAlmageed]

@Ali-Galal I'm using css media quires to make it fit height so could you please provide window.innerWidth by opening the console and write this window.innerWidth

[Ali-Galal]

[MoatazAbdAlmageed]

@Ali-Galal I mean chrome console like this (just click f12)

[Ali-Galal]

811

[MoatazAbdAlmageed]

Okay thanks please check again

…

On Wed, Feb 13, 2019, 3:03 PM Ali-Galal ***@***.*** wrote: 811 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#231 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQkXejCP5UA6zcqhjikkiwyYXjkxK75Mks5vNA05gaJpZM4ZWBrb> .