Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Research at Cambridge" link in global header broken in mobile displays #94

Open
alt36 opened this issue Jul 16, 2019 · 1 comment
Open

Comments

@alt36
Copy link
Contributor

alt36 commented Jul 16, 2019

When in mobile mode, the "Research at Cambridge" link in the global header becomes simply

<a href="">

i.e. the href attribute is empty, which leads to the link always being to the currently-viewed page.

I can see this on my Drupal site (https://www.ch.cam.ac.uk), a randomly-chosen Falcon-on-Plone site (https://www.phy.cam.ac.uk) and a PL site that is neither of those things (https://www.geog.cam.ac.uk), suggesting to me that the problem is in the "core" js in this repo. Curiously though, the link on https://www.cam.ac.uk - which I believe uses a non-standard PL implementation - works fine, so comparing with the js there might help identify the cause.

@tombsar
Copy link
Contributor

tombsar commented Jul 16, 2019

Issue also affects my site which is mostly a copy-paste of this repository. I don't see anything wrong with the html, so likely the Javascript is at fault. Possibly related to that link having class="campl-no-drawer"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants