Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of Device object - short term solution #9

Closed
Kevsy opened this issue Jun 7, 2024 · 3 comments
Closed

Simplification of Device object - short term solution #9

Kevsy opened this issue Jun 7, 2024 · 3 comments

Comments

@Kevsy
Copy link
Contributor

Kevsy commented Jun 7, 2024

Problem description

(note: text below pasted from equivalent issue in Connectivity Insights/other repos)

Commonalities discussed the topic and proposed the short term solution (for the coming meta-release) summarized in camaraproject/Commonalities#171 (comment) :

  • Apply the mechanism to rely on the access_token (not providing the device object in the API request) for 3-legged access scenarios.
  • Remove the networkAccessIdentifier from Device object

Reviewing and providing the feedback on the impact of the proposed solution on this subproject was suggested by the TSC.

Possible evolution
Review the proposed changes before Commonalities meeting on 10.06. camaraproject/Commonalities#171

Alternative solution
Review the PR related to camaraproject/Commonalities#171 (should be created soon)

Additional context
Initial proposal of text explaining using access token information to identify the target device of the API request: camaraproject/Commonalities#171 (comment)
Dedicated meeting summary:
https://wiki.camaraproject.org/display/CAM/2024-05-23+-+Commonalities+Ad-Hoc+Meeting+-+Device+Object+review

@Kevsy Kevsy self-assigned this Jun 7, 2024
@Kevsy Kevsy changed the title Simpli Simplification of Device object - short term solution Jun 7, 2024
@javierlozallu
Copy link
Contributor

@Kevsy I think this also affects to Traffic Influence and Endpoint Discovery APIs, as is being discussed on camaraproject/EdgeCloud#119.

Basically we tend to agree that Device Object IP could be:
"ipv4Address": {
"publicAddress": "203.0.113.0",
"publicPort": 59765
}

Apparently there is a meeting on 10.06 to conclude on the issue so I would be grateful if you could update us on the Edge Cloud meeting on 11.06.

@Kevsy
Copy link
Contributor Author

Kevsy commented Jul 11, 2024

Commonalities PR 233 was agreed and merged

This will be included in SED 0.11.0-alpha.1

@Kevsy
Copy link
Contributor Author

Kevsy commented Jul 22, 2024

Fixed in #30

@Kevsy Kevsy closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants