Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test definitions - linting results #149

Closed
rartych opened this issue Aug 29, 2024 · 2 comments
Closed

Test definitions - linting results #149

rartych opened this issue Aug 29, 2024 · 2 comments
Assignees

Comments

@rartych
Copy link
Contributor

rartych commented Aug 29, 2024

Problem description
While testing linting rules for Gherkin the following output was produced for checkSimSwap.feature

  18    Multiple empty lines are not allowed                                        no-multiple-empty-lines
  40    Scenario name is already used in: checkSimSwap.feature:32                   no-dupe-scenario-names
  67    Trailing spaces are not allowed                                             no-trailing-spaces

For retrieveSimSwapDate.feature
28 Multiple empty lines are not allowed no-multiple-empty-lines

Expected behavior

❗ Line number 9 in both files should be marked as comment - otherwise it is syntax error.

The most of issues are related to formatting.
But the optional scenario title is indeed duplicated in lines 32 and 40.

It should be considered to change the filenames of test definitions to kebab-case.

Alternative solution

Additional context

@bigludo7 bigludo7 self-assigned this Aug 29, 2024
@bigludo7
Copy link
Collaborator

Thanks @rartych
done !

@rartych
Copy link
Contributor Author

rartych commented Sep 6, 2024

Closing as fixed in release PR #148

@rartych rartych closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants