Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates of review issue template with more functionality #61

Closed
tanjadegroot opened this issue Jul 26, 2024 · 4 comments · Fixed by #62
Closed

Updates of review issue template with more functionality #61

tanjadegroot opened this issue Jul 26, 2024 · 4 comments · Fixed by #62
Labels
enhancement New feature or request

Comments

@tanjadegroot
Copy link
Collaborator

tanjadegroot commented Jul 26, 2024

Problem description

Extending the review issue template with informatiuon on release mgmt action beyond the API review

Possible evolution

Rename to "Review actions"

Add a section Release actions with the following as tickboxes

API Release Tracker available
Review comments addressed (by Sub Project)
Release PR approved (on behalf of Release Management)
PR merged (by Sub Project codeowner)
Release created within GitHub (by Sub Project codeowner)
Release Tracker updated (M3 date = creation date of release?)

@tanjadegroot tanjadegroot added the enhancement New feature or request label Jul 26, 2024
@tanjadegroot
Copy link
Collaborator Author

tanjadegroot commented Jul 26, 2024

@hdamker please check if it meets your proposal and merge.
We will need to manually extend to existing review issues by copying from the updated template

I will actually do a manual copy into the first to review issues (botttom up) and start to use it. This may leead to some additional points to add in the PR

@hdamker
Copy link
Collaborator

hdamker commented Jul 26, 2024

@hdamker please check if it meets your proposal and merge. We will need to manually extend to existing review issues by copying from the updated template
Looks good for me, comments in the PR. The update is not difficult, just replace the yet untouched part of the issue description.

I will actually do a manual copy into the first to review issues (botttom up) and start to use it. This may leead to some additional points to add in the PR

Testing is good, I currently doing it with DeviceStatus in #57

@tanjadegroot
Copy link
Collaborator Author

There is no real easy way to check the Commonalities / ICM alignment (beyond version and Auth section in info.description. Some teams have put the linter output snapshot in the issue

should we ask both teams to add a short main check points list on the confluence page ? https://wiki.camaraproject.org/display/CAM/Guidance+for+release+review

@hdamker
Copy link
Collaborator

hdamker commented Jul 27, 2024

There is no real easy way to check the Commonalities / ICM alignment (beyond version and Auth section in info.description. Some teams have put the linter output snapshot in the issue

should we ask both teams to add a short main check points list on the confluence page ? https://wiki.camaraproject.org/display/CAM/Guidance+for+release+review

Yes, a checklist makes sense to me. About doing the actual check: maybe the experts from Commonalities and ICM are best suited to do these checks. Maybe not blocking the creation of the release candidates, but based on the actual release candidates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants