Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Release for Fall24 meta-release #70

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Public Release for Fall24 meta-release #70

merged 5 commits into from
Sep 6, 2024

Conversation

jpengar
Copy link
Collaborator

@jpengar jpengar commented Aug 22, 2024

What type of PR is this?

  • subproject management

What this PR does / why we need it:

Public release (r1.2) for 0.4.0 version of the HomeDevicesQoD API.

Which issue(s) this PR fixes:

Fixes #69
Related to #63

Special notes for reviewers:

N/A

Changelog input

 Public release of home-devices-qod v0.4.0

Additional documentation

https://wiki.camaraproject.org/display/CAM/Meta-release+Fall24
https://wiki.camaraproject.org/display/CAM/home-devices-qod+v0.4.0

@jpengar jpengar requested a review from a team August 22, 2024 11:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 1.57s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.69s
✅ YAML yamllint 1 0 0.3s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

This was referenced Aug 22, 2024
Closed
Closed
@hdamker hdamker mentioned this pull request Aug 22, 2024
Closed
11 tasks
hdamker
hdamker reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just two suggestions.

Not yet the official review - but thanks a lot for providing it early. An example how it should look like.

CHANGELOG.md Outdated Show resolved Hide resolved
documentation/API_documentation/home-devices-qod-API-Readiness-Checklist.md Outdated Show resolved Hide resolved
jpengar and others added 2 commits August 22, 2024 15:39
@jpengar @hdamker
Update CHANGELOG.md
d2da7c1 
Added Herbert suggestion

Co-authored-by: Herbert Damker <[email protected]>
@jpengar
Added Herbert's suggested changes
dc2a578
@jpengar jpengar requested a review from hdamker August 22, 2024 13:46
@hdamker
Copy link
Contributor

hdamker commented Aug 22, 2024

Thanks a lot @jpengar. Now we have a poster child for a great release PR :-)
cc: @bigludo7

fernandopradocabrillo
fernandopradocabrillo approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM

@hdamker hdamker requested review from a team and removed request for hdamker August 23, 2024 15:33
@hdamker
Copy link
Contributor

hdamker commented Aug 23, 2024

Just to avoid misunderstanding: please wait for with the merge of this PR the official approval from Release Management .

@jpengar
Copy link
Collaborator Author

jpengar commented Aug 26, 2024

Just to avoid misunderstanding: please wait for with the merge of this PR the official approval from Release Management .

@hdamker Of course, I didn't plan to merge the PR before release management approval.

@hdamker hdamker mentioned this pull request Aug 27, 2024
Merged
bigludo7
bigludo7 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the release-management_maintainers

@jpengar jpengar merged commit ebf88ea into main Sep 6, 2024
1 check passed
@jpengar jpengar deleted the jpengar/r1.2 branch September 6, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdamker hdamker hdamker left review comments

@fernandopradocabrillo fernandopradocabrillo fernandopradocabrillo approved these changes

@bigludo7 bigludo7 bigludo7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convention for file names of API definition
4 participants
@jpengar @hdamker @bigludo7 @fernandopradocabrillo