Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sink credentials sent back as a part of API responses. #296

Closed
shilpa-padgaonkar opened this issue Sep 5, 2024 · 3 comments
Closed

Sink credentials sent back as a part of API responses. #296

shilpa-padgaonkar opened this issue Sep 5, 2024 · 3 comments
Labels
correction correction in documentation duplicate This issue or pull request already exists

Comments

@shilpa-padgaonkar
Copy link
Collaborator

Problem description
For APIs where we have either implicit or explicit subscriptions, as a part of a successful response, we send back the sink credentials.
IMHO we should exclude this information from the response.

Expected behavior
Do not send back sink credentials as a part of the API responses.

Alternative solution

Additional context

@shilpa-padgaonkar shilpa-padgaonkar added the correction correction in documentation label Sep 5, 2024
@PedroDiez
Copy link
Collaborator

Related Issue Design Guidelines should provide guidance about sinkCredentials in returned/retrieved subscription objects #276

@rartych rartych added duplicate This issue or pull request already exists labels Sep 16, 2024
@rartych
Copy link
Collaborator

rartych commented Sep 16, 2024

@rartych
Copy link
Collaborator

rartych commented Dec 9, 2024

Closing as resolved in #313

@rartych rartych closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants