Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the "sink" property description #289

Closed
PedroDiez opened this issue Aug 30, 2024 · 3 comments · Fixed by #313
Closed

Update the "sink" property description #289

PedroDiez opened this issue Aug 30, 2024 · 3 comments · Fixed by #313
Assignees
Labels
correction correction in documentation Spring25 subscriptions

Comments

@PedroDiez
Copy link
Collaborator

Problem description
Within Commonalities MetaRelease Fall 24. It has been agreed so far the unique use of HTTP protocol for "callback URLs"

Some in-advance decision has been made for QoD on Demand and Carrier Billing Checkout

Expected behavior
Update and align in commonalities artifacts the suitable wording for "sink" description:

The address to which events shall be delivered, using the HTTP protocol.

Alternative solution
Not considered so far, open to discussion in any case.

Additional context
[Issue opened in Carrier Billing Checkout]CarrierBillingCheckout/Issue#168(camaraproject/CarrierBillingCheckOut#168)

Issue proposed for MetaRelease Spring 25 - #273

@PedroDiez PedroDiez added the correction correction in documentation label Aug 30, 2024
@bigludo7
Copy link
Collaborator

bigludo7 commented Oct 1, 2024

Hello @PedroDiez

To fix this one the proposal is to correct the table here to change the attribute description for the sink attribute.

Nothing to do on the event-subscription-template.yaml as the sink attribute description is already the right one.

Agreed on the resolution?
@rartych you can assign this one to me and tag subscriptions ;)

@PedroDiez
Copy link
Collaborator Author

Hi,

Agree to correct description on the table you mention @bigludo7 and i think also makes sense to align the wording in the event-subscription-template.yaml

https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml#L297C24-L297C99

@bigludo7
Copy link
Collaborator

bigludo7 commented Oct 2, 2024

Thanks @PedroDiez - clear for me.
Will do

bigludo7 added a commit to bigludo7/Commonalities that referenced this issue Oct 10, 2024
Update the "sink" property descriptionFix camaraproject#289
@rartych rartych linked a pull request Nov 25, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation Spring25 subscriptions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants