From e43a95c42cb3bc6ca64fe62fc2f3e4bae94cdaf3 Mon Sep 17 00:00:00 2001
From: FabrizioMoggio <87469955+FabrizioMoggio@users.noreply.github.com>
Date: Tue, 16 Jul 2024 14:08:31 +0200
Subject: [PATCH] Errors reordering

404 moved after 403
---
 ...forwarding-signal-every-forwarding.feature | 22 +++++++++----------
 ...ll-forwarding-signal-unconditional.feature | 22 +++++++++----------
 2 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/code/Test_definitions/call-forwarding-signal-every-forwarding.feature b/code/Test_definitions/call-forwarding-signal-every-forwarding.feature
index 9f923ba..c124065 100644
--- a/code/Test_definitions/call-forwarding-signal-every-forwarding.feature
+++ b/code/Test_definitions/call-forwarding-signal-every-forwarding.feature
@@ -104,17 +104,6 @@ Feature: CAMARA Call Fowarwing Signal  API, v0.1.0 - Operation call-forwardings
 
   # Error path scenarios
 
- # Generic 404 error - unknown phone number
-  @call_forwarding_signal_03_unconditional_call_forwarding_for_unknown_phone_number
-  Scenario: retrieve call forwarding signal on a properly formatted phone number unknown by the network
-    Given the request body property "$.phoneNumber" is set to a valid phone number for which the call forwarding status could not be retrieved
-    And the request body is set to a valid request body
-    And "login_hint" is set to a valid phone number supported by the service with the same value as "$.phoneNumber", if valorised.
-    When the HTTP "POST" request is sent
-    Then the response status code is 404
-    And the response property "$.code" is "CALL_FORWARDING.UNKNOWN_PHONE_NUMBER"
-    And the response property "$.message" contains a user friendly text
-
   # Generic 400 error - input error
   @call_forwarding_signal_400.1_no_request_body
   Scenario: Missing request body
@@ -163,6 +152,17 @@ Feature: CAMARA Call Fowarwing Signal  API, v0.1.0 - Operation call-forwardings
       And the response property "$.status" is 403
       And the response property "$.code" is "INVALID_TOKEN_CONTEXT"
       And the response property "$.message" contains a user friendly text
+ 
+ # Generic 404 error - unknown phone number
+  @call_forwarding_signal_03_unconditional_call_forwarding_for_unknown_phone_number
+  Scenario: retrieve call forwarding signal on a properly formatted phone number unknown by the network
+    Given the request body property "$.phoneNumber" is set to a valid phone number for which the call forwarding status could not be retrieved
+    And the request body is set to a valid request body
+    And "login_hint" is set to a valid phone number supported by the service with the same value as "$.phoneNumber", if valorised.
+    When the HTTP "POST" request is sent
+    Then the response status code is 404
+    And the response property "$.code" is "CALL_FORWARDING.UNKNOWN_PHONE_NUMBER"
+    And the response property "$.message" contains a user friendly text
 
  # Generic 409 error - conflict
  @call_forwarding_signal_409.1_already_exists
diff --git a/code/Test_definitions/call-forwarding-signal-unconditional.feature b/code/Test_definitions/call-forwarding-signal-unconditional.feature
index add11b5..aea29ac 100644
--- a/code/Test_definitions/call-forwarding-signal-unconditional.feature
+++ b/code/Test_definitions/call-forwarding-signal-unconditional.feature
@@ -70,17 +70,6 @@ Feature: CAMARA Call Fowarwing Signal  API, v0.1.0 - Operation unconditional-cal
 
   # Error path scenarios
   
-  # Generic 404 error - unknown phone number
-  @call_forwarding_signal_03_unconditional_call_forwarding_for_unknown_phone_number
-  Scenario: retrieve call forwarding signal on a properly formatted phone number unknown by the network
-    Given the request body property "$.phoneNumber" is set to a valid phone number for which the unconditional call forwarding status could not be retrieved
-    And the request body is set to a valid request body
-    And "login_hint" is set to a valid phone number supported by the service with the same value as "$.phoneNumber", if valorised.
-    When the HTTP "POST" request is sent
-    Then the response status code is 404
-    And the response property "$.code" is "CALL_FORWARDING.UNKNOWN_PHONE_NUMBER"
-    And the response property "$.message" contains a user friendly text
-
   # Generic 400 error - input error
   @call_forwarding_signal_400.1_no_request_body
   Scenario: Missing request body
@@ -129,6 +118,17 @@ Feature: CAMARA Call Fowarwing Signal  API, v0.1.0 - Operation unconditional-cal
       And the response property "$.status" is 403
       And the response property "$.code" is "INVALID_TOKEN_CONTEXT"
       And the response property "$.message" contains a user friendly text
+  
+  # Generic 404 error - unknown phone number
+  @call_forwarding_signal_03_unconditional_call_forwarding_for_unknown_phone_number
+  Scenario: retrieve call forwarding signal on a properly formatted phone number unknown by the network
+    Given the request body property "$.phoneNumber" is set to a valid phone number for which the unconditional call forwarding status could not be retrieved
+    And the request body is set to a valid request body
+    And "login_hint" is set to a valid phone number supported by the service with the same value as "$.phoneNumber", if valorised.
+    When the HTTP "POST" request is sent
+    Then the response status code is 404
+    And the response property "$.code" is "CALL_FORWARDING.UNKNOWN_PHONE_NUMBER"
+    And the response property "$.message" contains a user friendly text
 
   # Generic 409 error - conflict
   @call_forwarding_signal_409.1_already_exists