Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add functionality to iterator returned for results #1

Open
mhucka opened this issue Mar 16, 2019 · 0 comments
Open

Add functionality to iterator returned for results #1

mhucka opened this issue Mar 16, 2019 · 0 comments
Labels
Coding: enhancement ✨ New feature or request Status: help wanted 👋🏽 Extra attention is needed

Comments

@mhucka
Copy link
Collaborator

mhucka commented Mar 16, 2019

Currently, the queryresults object returned by dimensions.query(...) implements the iterator protocol and the additional ability to take the len(...) only. It would be convenient if the results object could supported slicing, and possibly other operations such as list(results). This wouldn't be very hard to implement, and the Python itertools package provides some features that could be useful in the implementation. The main design decisions revolve around how to store the results internally (when they could be very many, as many as 50,000) and what to do if the user tries to use list(results) on a long list of results (which will hang during the time that Sidewall is repeatedly querying the Dimensions server to fill out the list).

@mhucka mhucka added Coding: enhancement ✨ New feature or request Status: help wanted 👋🏽 Extra attention is needed labels Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Coding: enhancement ✨ New feature or request Status: help wanted 👋🏽 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant