Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use thumbor? #21

Open
sylae opened this issue Dec 1, 2016 · 1 comment
Open

Add option to use thumbor? #21

sylae opened this issue Dec 1, 2016 · 1 comment

Comments

@sylae
Copy link

sylae commented Dec 1, 2016

A common problem on the chat is people (myself included, sorry!) posting images that are...large. Not only does it fill the screen with an occasionally-undesirable image, it also wastes client bandwidth.

Since a couple days ago, I've been using a thumbor install to resize stuff for files.calref. It would be a nice option to add this to cadence, if possible. I'm not too familar with New Cadence, but the easy fix would be to just change the [img] tag parser a bit? The hard fix would be adding a user customization option to that to toggle thumbing incoming images (which we should do if this is a thing that interests people).

Thumbor itself is really simple, just prefix the existing url with something like:

http://thumbor.tld:port/500x500/smart/(original url)

and it'll do the rest :)

@cburschka
Copy link
Collaborator

cburschka commented Dec 1, 2016

The magic of cadence2's config system allows us to override xbbcode tags directly from the calref.yml install profile, so I'd suggest using the outgoing option. (Incoming would require changing a whole bunch of code, and since thumbor afaik requires you to set up your own server, it'd be a bit impractical to put it in the upstream code.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants