Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

theme's text is rendered wrong (centred) on Firefox #98

Open
nuno-silva opened this issue Mar 25, 2020 · 3 comments
Open

theme's text is rendered wrong (centred) on Firefox #98

nuno-silva opened this issue Mar 25, 2020 · 3 comments

Comments

@nuno-silva
Copy link
Contributor

nuno-silva commented Mar 25, 2020

On Firefox, all blog contents appear centred instead of left-aligned.

I believe this is due to text-align: center; being applied to body here (which Firefox seems to apply to everything):

body {
padding-top: 55px;
display: flex;
text-align: center;
flex-direction: column;
}

I am not sure which of the renderings is correct, but I believe text should not be centred, since this also affects code blocks (see screenshot below).

Here's a few screenshots of one the example site's posts (https://themes.gohugo.io//theme/minimal/post/markdown-syntax/):

Firefox 73

firefox_73_themes gohugo io

Code blocks look specially awful 😢 (also firefox):

firefox_73_themes gohugo io_codeblocks

Chromium 80

chromium80_themes gohugo io__theme_minimal_post_markdown-syntax_

urlscan.io

https://urlscan.io/result/3467c0f9-8193-424b-9cad-b9ce70cb359f/compare
urlscan.io screenshot

@jaqmol
Copy link

jaqmol commented Mar 28, 2020

Same problem here. Removing the max-width from the main element seems to solves the problem.

@jaqmol
Copy link

jaqmol commented Mar 28, 2020

Also: having the font-size connected to the height of the viewport is a bad decision for mobile! It's forced to scale badly like that on portrait proportions screens.

cuonglm added a commit to cuonglm/cuonglm.xyz that referenced this issue Aug 17, 2021
@jimmysjolund
Copy link

Any ideas for workaround? I don't get the suggestion to remove max-width to work. I really like the theme but need to get it to work on Firefox as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants