Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add rust husky #977

Closed
wants to merge 20 commits into from
Closed

chore: add rust husky #977

wants to merge 20 commits into from

Conversation

MatejVukosav
Copy link
Member

@MatejVukosav MatejVukosav commented Nov 20, 2024 •
edited
Loading

  • use husky-rs instead of regular husky
  • use dprint instead of prettier
  • fix md files based on dprint
  • remove unused eslint files

Note
After this is merged; execute cargo clean and cargo build to setup husky

@MatejVukosav MatejVukosav self-assigned this Nov 20, 2024
@MatejVukosav MatejVukosav force-pushed the chore--add-rust-husky branch 5 times, most recently from d75c38a to ec9e538 Compare November 20, 2024 09:35
@MatejVukosav MatejVukosav changed the title Chore add rust husky chore: add rust husky Nov 20, 2024
@MatejVukosav MatejVukosav requested a review from miraclx November 21, 2024 04:20
@MatejVukosav MatejVukosav requested review from alenmestrov, miraclx, petarjuki7 and fbozic and removed request for miraclx November 21, 2024 04:20
miraclx
miraclx reviewed Nov 21, 2024
View reviewed changes
crates/merod/Cargo.toml
@@ -36,6 +36,7 @@ calimero-node = { path = "../node" }
calimero-network = { path = "../network" }
calimero-server = { path = "../server", features = ["jsonrpc", "websocket", "admin"] }
calimero-store = { path = "../store" }
husky-rs.workspace = true # activate husky hooks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be [dev-dependencies]?

.prettierignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these accounted for someway with dprint?

Cargo.lock Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Stale label Nov 28, 2024
@MatejVukosav
Copy link
Member Author

Bump

@github-actions github-actions bot removed the Stale label Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Stale label Dec 7, 2024
@github-actions GitHub Actions
Copy link

"This pull request has been automatically closed because it has been inactive for more than 7 days. Please reopen and see this PR through its review if it is essential."

@github-actions github-actions bot closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraclx miraclx miraclx left review comments

@alenmestrov alenmestrov Awaiting requested review from alenmestrov

@petarjuki7 petarjuki7 Awaiting requested review from petarjuki7

@fbozic fbozic Awaiting requested review from fbozic

Assignees

@MatejVukosav MatejVukosav

Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatejVukosav @miraclx