Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce a secret key for encryption type into context identity #863

Merged
merged 39 commits into from
Nov 13, 2024
Merged

feat: introduce a secret key for encryption type into context identity #863

merged 39 commits into from
Nov 13, 2024

Conversation

chefsale
Copy link
Member

@chefsale chefsale commented Oct 25, 2024 •
edited
Loading

WIP, waiting for @miraclx and catchup.

miraclx
miraclx reviewed Oct 25, 2024
View reviewed changes
crates/context/src/lib.rs Outdated Show resolved Hide resolved
miraclx
miraclx reviewed Oct 25, 2024
View reviewed changes
crates/context/src/lib.rs Outdated Show resolved Hide resolved
crates/context/src/lib.rs Outdated Show resolved Hide resolved
@chefsale chefsale force-pushed the introduce-encryption-key-broadcast2 branch 19 times, most recently from 0a44932 to 93c5ed9 Compare October 25, 2024 15:00
@chefsale chefsale force-pushed the introduce-encryption-key-broadcast2 branch from da304f3 to 38fb2c9 Compare October 25, 2024 15:05
@chefsale chefsale force-pushed the introduce-encryption-key-broadcast2 branch from b9b01d8 to 592e4ff Compare October 25, 2024 15:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Stale label Nov 2, 2024
@chefsale
Copy link
Member Author

chefsale commented Nov 4, 2024

@petarjuki7 to take over this PR

@chefsale chefsale removed the Stale label Nov 4, 2024
@petarjuki7 petarjuki7 requested a review from miraclx November 11, 2024 10:25
miraclx
miraclx reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please test it out and make sure blob sync works as expected, once that is confirmed, I'll stamp it

miraclx
miraclx reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, key sharing is missing

@petarjuki7 petarjuki7 requested a review from miraclx November 12, 2024 13:02
miraclx
miraclx reviewed Nov 12, 2024
View reviewed changes
crates/node/src/interactive_cli.rs Outdated Show resolved Hide resolved
crates/node/src/sync.rs Outdated Show resolved Hide resolved
crates/node/src/sync.rs Outdated Show resolved Hide resolved
crates/node/src/sync/key_share.rs Outdated Show resolved Hide resolved
crates/node/src/sync/key_share.rs Outdated Show resolved Hide resolved
crates/node/src/sync/key_share.rs Outdated Show resolved Hide resolved
crates/node/src/sync/key_share.rs Outdated Show resolved Hide resolved
crates/node/src/sync/state.rs Outdated Show resolved Hide resolved
crates/node/src/types.rs Outdated Show resolved Hide resolved
file.patch Outdated Show resolved Hide resolved
miraclx
miraclx reviewed Nov 12, 2024
View reviewed changes
crates/context/src/lib.rs Outdated Show resolved Hide resolved
crates/node/src/sync/key.rs Outdated Show resolved Hide resolved
crates/node/src/sync/key.rs Outdated Show resolved Hide resolved
miraclx
miraclx reviewed Nov 12, 2024
View reviewed changes
crates/node/src/sync.rs Outdated Show resolved Hide resolved
@petarjuki7 petarjuki7 requested a review from miraclx November 12, 2024 16:48
miraclx
miraclx reviewed Nov 12, 2024
View reviewed changes
crates/context/src/lib.rs Outdated Show resolved Hide resolved
crates/node/src/sync/key.rs Outdated Show resolved Hide resolved
@petarjuki7 petarjuki7 enabled auto-merge (squash) November 13, 2024 13:32
miraclx
miraclx approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside this, rest looks good to me

crates/crypto/src/lib.rs Outdated Show resolved Hide resolved
@petarjuki7 petarjuki7 merged commit 9a2ae39 into master Nov 13, 2024
15 checks passed
@petarjuki7 petarjuki7 deleted the introduce-encryption-key-broadcast2 branch November 13, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petarjuki7 petarjuki7 petarjuki7 left review comments

@miraclx miraclx miraclx approved these changes

Assignees

@petarjuki7 petarjuki7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chefsale @petarjuki7 @miraclx