-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement bootstrap in meroctl #1016
Conversation
bef6caa
to
ad12be9
Compare
ad12be9
to
829851b
Compare
829851b
to
6d1006f
Compare
…add-bootstrap-to-meroctl
0ded450
to
4bf359f
Compare
4bf359f
to
8fcd2a1
Compare
…add-bootstrap-to-meroctl
…network/core into feat--add-bootstrap-to-meroctl
7d39a46
to
fb2e228
Compare
Run tests locally and they are passing @fbozic did you saw this error before? |
bfce2d4
to
8a92b6a
Compare
c99fef6
to
123a6d8
Compare
123a6d8
to
629b569
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't use println in the commands, please use environment.output.
. Because we consume command output in multiple formats. Potentially, this breaks your e2e-tests.
3794bd8
to
d49f87e
Compare
…add-bootstrap-to-meroctl
d49f87e
to
3744997
Compare
TODO v2
Test
cargo run -p meroctl -- --node-name node1 --home data bootstrap start --merod-path {path} --app-path {path}
or with app download
cargo run -p meroctl -- --node-name node1 --home data bootstrap start --merod-path {path}
If user didn't provide app-path, instructions at the bottom of log are provided. Otherwise not.
Log