Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update docker compose to remove coordinator #1001

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: update docker compose to remove coordinator #1001

merged 1 commit into from
Dec 4, 2024

Conversation

MatejVukosav
Copy link
Member

No description provided.

@MatejVukosav MatejVukosav requested a review from fbozic December 4, 2024 10:27
@MatejVukosav MatejVukosav self-assigned this Dec 4, 2024
@fbozic fbozic requested a review from miraclx December 4, 2024 10:29
fbozic
fbozic approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@fbozic fbozic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it useful to have a single node in docker compose. @miraclx what do you think?

@miraclx
Copy link
Member

miraclx commented Dec 4, 2024

Yeah, I agree.. I mean it could've worked if compose run --name {node1,node2} was defined, but we will then have port contention on the host.

And if we made that randomly assigned, then the console output would be printing a port of the container, not the host, so it gets a bit confusing.

I think it makes sense to define an example compose file, and let the user modify it to fit their needs.

@MatejVukosav
Copy link
Member Author

Let's create an issue for that.

@MatejVukosav MatejVukosav mentioned this pull request Dec 4, 2024
Open
@MatejVukosav MatejVukosav merged commit f62ad06 into master Dec 4, 2024
10 checks passed
@MatejVukosav MatejVukosav deleted the fix--update-docker-compose-to-remove-coordinator branch December 4, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbozic fbozic fbozic approved these changes

@miraclx miraclx miraclx approved these changes

Assignees

@MatejVukosav MatejVukosav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatejVukosav @miraclx @fbozic