Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shadydom in IE11 #68

Closed
zhoukekestar opened this issue Apr 12, 2022 · 4 comments
Closed

Support shadydom in IE11 #68

zhoukekestar opened this issue Apr 12, 2022 · 4 comments

Comments

@zhoukekestar
Copy link

Hi, thanks for your awesome project ! We try it in IE 11, run most code correctly but find some wrong in webcomponents polyfill.

You can find detail in this issue: webcomponents/polyfills#504 .

I think it can be fixed very simple by modify attachShadowObserver like this:

 try {
    observer.observe(shadowRoot, observerConfig);
  } catch (err) {
    console.info('observe shadowRoot to this');
   // we can just observe parent element in IE11, the code will run correctly.
    observer.observe(this, observerConfig);
  }
@calebdwilliams
Copy link
Owner

Is this specifically to do with ShadyDOM? If so I can just add that if the polyfill exists.

@zhoukekestar
Copy link
Author

Yes, do different logic by detect shadydom is a better way.

@calebdwilliams
Copy link
Owner

@zhoukekestar can you try [email protected]

@zhoukekestar
Copy link
Author

Test 1.1.3 on IE 11, and it works now. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants