Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKING] reCAPTCHA and related design changes #2537

Open
9 tasks
machikoyasuda opened this issue Nov 26, 2024 · 2 comments
Open
9 tasks

[TRACKING] reCAPTCHA and related design changes #2537

machikoyasuda opened this issue Nov 26, 2024 · 2 comments
Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework

Comments

@machikoyasuda
Copy link
Member

machikoyasuda commented Nov 26, 2024

This is the design ticket: #2494

Recommended order of dev tickets:

All these tickets should be completed before a deploy.

The one open question: Whether the Ageny card form page needs the text. I'm leaning towards no, but need 100% confirmation from @indexing

@machikoyasuda machikoyasuda changed the title [TRACKING] reCAPTCHA and related design changes [TRACKING]: reCAPTCHA and related design changes Nov 26, 2024
@machikoyasuda
Copy link
Member Author

machikoyasuda commented Nov 26, 2024

@thekaveman @angela-tran @lalver1

I ended up making tickets for the realignment of each page, as it requires changing every individual template for every flow (rather than say, being able to easily change all of this in 1 base template file or 1 CSS change), and I wanted to make smaller PRs that are focused and easier to QA. Aside from the last ticket (text realignment 24px/72px), all the tickets can be done synchronously by the whole team - since there aren't depenencies and they're on different files. I imagine most of these PRs will involve deleting CSS and making a small CSS class change (like from col-lg-8 to col-lg-6).

If finishing all of these tickets then reveals to us that greater refactors can be made to template files or CSS (which I do anticipate!), I think that should be a new ticket for the future, and should be discussed when the whole reCAPTCHA removal project is complete. The focus of these tickets is to get the app in a clean deployable state.

@indexing
Copy link
Member

@machikoyasuda Response to your question in the description here: #2494.

TL;DR Let's add the informational copy everywhere we use reCaptcha.

@machikoyasuda machikoyasuda changed the title [TRACKING]: reCAPTCHA and related design changes [TRACKING] reCAPTCHA and related design changes Nov 26, 2024
@thekaveman thekaveman added front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
Status: Todo
Development

No branches or pull requests

3 participants