Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up EnrollmentFlow labels in dev, test, and prod to remove prefix #2511

Closed
2 tasks done
angela-tran opened this issue Nov 6, 2024 · 5 comments
Closed
2 tasks done
Assignees
Labels
configuration Changes to the configuration of our deployed web apps

Comments

@angela-tran
Copy link
Member

angela-tran commented Nov 6, 2024

Acceptance Criteria

  • Flows in dev, test, and prod have their labels cleaned up (see Additional Context below)
  • Document on this ticket the changes that were made

Additional context

With #2403 merged in, we don't need to have a prefix in the label of EnrollmentFlows that says which transit agency the flow is for; the table shows us that information already.

image

Also, recall that the EnrollmentFlow's label is used as the text for the radio buttons when selecting a transit benefit during in-person enrollment. So in general, the label should be what we want the users of Benefits Administrator to see.

More specifically, if the flow is digital, we should use the same copy as what's in the flow's selection_label_template, e.g. for Medicare flows, we'd want to use "Medicare Cardholder" since that's what's in the selection label template.

#2336 is the ticket that this configuration change corresponds to.

@angela-tran angela-tran moved this from Todo to Stretch in Digital Services Nov 6, 2024
@angela-tran angela-tran added the configuration Changes to the configuration of our deployed web apps label Nov 6, 2024
@angela-tran
Copy link
Member Author

angela-tran commented Nov 6, 2024

@lalver1 I noticed while working on #2503 and #2510 that in test, the Nevada County flows were created with labels that are prefixed with (NevCo). Just wanted to note that when we create new EnrollmentFlows, we should not use the old pattern for label.

Doing this ticket will help ensure no one is mislead by labels lingering around with the old pattern. Note this ticket is not on the sprint, so should be worked on if we finish all sprint items or during slush time.

@angela-tran angela-tran self-assigned this Nov 26, 2024
@angela-tran angela-tran moved this from Stretch to In progress in Digital Services Nov 26, 2024
@angela-tran
Copy link
Member Author

angela-tran commented Nov 26, 2024

Updated flow labels in dev-benefits.calitp.org/admin

Before

Image

After

Image

@angela-tran
Copy link
Member Author

angela-tran commented Nov 27, 2024

Updated flow labels in test-benefits.calitp.org/admin

Note: while updating these, I read the system names and labels for the Nevada County Connects in-person flows more closely. Are these the correct values? I'd like to avoid us accidentally using inconsistent values and having to do analytics data clean-up later. (I've only heard of us planning to use disabled from #2355)

At the very least, I removed the (NevCo) prefix from their labels.

Values in question:

System name ("Event/User Properties Enrollment Flow" in Metabase) Label (shown in in-person enrollment)
disability Disability
youth Youth

Before

Image

After

Image

@angela-tran
Copy link
Member Author

Updated flow labels in benefits.calitp.org/admin

Before

Image

After

Image

@angela-tran
Copy link
Member Author

Done with configuration changes. I'll raise the question about those flows in test-benefits outside of this issue when we come back from break.

@github-project-automation github-project-automation bot moved this from In progress to Done in Digital Services Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Changes to the configuration of our deployed web apps
Projects
Status: Done
Development

No branches or pull requests

1 participant