update stan #300
Merged
update stan #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordSimal
force-pushed
the
3.x-update-stan
branch
from
eab160e to
f7be0fb
Compare
ADmad
reviewed
Nov 17, 2024
| path: src/Controller/Component/AuthorizationComponent.php | ||
|
|
||
| - | ||
| message: '#^Cannot call method getIdentifier\(\) on array\|Authentication\\IdentityInterface\.$#' |
There was a problem hiding this comment.
This error should actually be addressed at some point, good for now.
There was a problem hiding this comment.
we have that prop as ArrayAccess|array with native PHP attributes but overwritten with @var \Authentication\IdentityInterface because of the nature of it being a decorator implementation.
Haven't taken too much time thinking about it but feels pretty hard to get stan to understand that correctly.
There was a problem hiding this comment.
Yes it's a tricky one, hence I too have been ignoring it 😛.
LordSimal
force-pushed
the
3.x-update-stan
branch
from
f7be0fb to
69f231b
Compare
ADmad
reviewed
Nov 17, 2024
LordSimal
force-pushed
the
3.x-update-stan
branch
from
69f231b to
681e819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.