Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pre-commit GitHub action to Azure Pipelines - Pipeline Creation & Testing #437

Open
ram-kishore-odi opened this issue Nov 26, 2024 · 4 comments
Assignees

Comments

@ram-kishore-odi
Copy link
Contributor

ram-kishore-odi commented Nov 26, 2024

We currently drive CI through GitHub actions. We need to convert that to Azure Pipelines for the Azure DevOps flavored MDSA project repo. This is the second ticket related to pre-commit Github action conversion to Azure pipeline. This ticket takes care of adding a sample pipeline and testing this functionality.

The first ticket related to this is https://github.com/orgs/cagov/projects/31/views/39?sliceBy%5Bvalue%5D=ram-kishore-odi&pane=issue&itemId=84385198&issue=cagov%7Ccaldata-dse-internal-tracker%7C20. which takes of the conversion portion

@ram-kishore-odi ram-kishore-odi self-assigned this Nov 26, 2024
@summer-mothwood
Copy link
Contributor

Ran into this while researching dbt Cloud updates -- dbt Cloud has new merge jobs that are meant to remove the necessity for some Github actions. This couldn't take the place of all of our Github Actions as it's pretty limited, but might be worth a look:

Merge jobs for implementing continuous deployment (CD) workflows are now GA in dbt Cloud. Previously, you had to either set up a custom GitHub action or manually build the changes every time a pull request is merged.

@ian-r-rose
Copy link
Member

Yeah, it may be that we can remove the pre-commit action all-together now that dbt cloud CI jobs can run sqlfluff.

We do other checks in the pre-commit job:

  • linting/formatting YAML
  • linting/formatting Python
  • Validating JSON
  • Checking for stray merge conflict markers
  • Checking for AWS credentials
  • Checking for common typos

That said, sqlfluff is the most important for a dbt-focused project, and the simplification gained for clients who don't want to maintain a YAML CI pipeline might be worth the trade-off

@ian-r-rose
Copy link
Member

I would still like to have the option of an Azure pipeline CI job for clients who don't want to adopt dbt Cloud, but being able to run sqlfluff in dbt Cloud would take some of the time pressure off

@ram-kishore-odi
Copy link
Contributor Author

Kevin has reached out to CDT to see if they have any guidance in response the request that was sent to him - Update from 12/11/24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants