Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Tactile Feedback for Zwift Play controllers (and Ride?) #2752

Open
GraVvVel opened this issue Nov 7, 2024 · 30 comments · Fixed by #2753
Open

[REQ] Tactile Feedback for Zwift Play controllers (and Ride?) #2752

GraVvVel opened this issue Nov 7, 2024 · 30 comments · Fixed by #2753
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@GraVvVel
Copy link

GraVvVel commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
Nope

Describe the solution you'd like
On Zwift gearing you get subtle tactile feedback in the Zwift Play controllers for each gear shift. I would be nice to replicate this in QZ when connecting Zwift Play controllers with it and using it for gear shifts

Describe alternatives you've considered
None

Additional context
None

@GraVvVel GraVvVel added the enhancement New feature or request label Nov 7, 2024
@cagnulein
Copy link
Owner

cagnulein commented Nov 7, 2024 via email

Copy link

stale bot commented Nov 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 23, 2024
@cagnulein
Copy link
Owner

cagnulein commented Nov 28, 2024 via email

@satchafunkilus
Copy link

So are you saying it won't be possible to implement the vibration? Would be happy to do any testing, if it helps.

Not sure if a ding in the app would help much - I guess it's a question of taste, but I would find it rather annoying and leave it turned off. What I would see as a benefit in the app would be a TTS readout of the new gear.

@cagnulein
Copy link
Owner

So are you saying it won't be possible to implement the vibration? Would be happy to do any testing, if it helps.

no i just said that i tried but it's harder than i was expecting. I just gave it a single test. If a ding is not useful let's stay with the master plan :)

I will try again in the next weeks

@stale stale bot removed the wontfix This will not be worked on label Nov 28, 2024
@cagnulein
Copy link
Owner

TTS is it already a thing, if you want i can add a tts for the gear too

@satchafunkilus
Copy link

I know about the TTS, but as far as I understand only reads the current values in certain predefined intervals. In this case we would need a read out directly when shifting, or ideally with a small delay (1s?), so that it ignores multiple quick shifts at once and only reads out the "final" gear

@cagnulein
Copy link
Owner

yes i mean I can do it :) but i guess for you the vibrate feedback is better or also tts in tandem with it could be a good thing?

@satchafunkilus
Copy link

It's two completely different topics, I would say. I would love both.

@cagnulein
Copy link
Owner

@satchafunkilus are you watching this too? #2751 (comment)
I just finished it in case you are interested

@satchafunkilus
Copy link

Sounds cool, happy to check it out as well. For this function in particular, I could imagine a beep/click or some audible feedback to make sense, so you know how many gears have changed, especially if there is a small delay in the trainer. Could of course also be solved by the vibration ideally, but I think in this case some fallback would be great, as long as we don't have vibration. Otherwise I would imagine it very hard to know how long to keep the button pressed.

@cagnulein
Copy link
Owner

@satchafunkilus
send me an email to roberto.viola83 at gmail.com indicating this ticket and if you are on android or iOS. Thanks

i added a 0.5 delay. so it's backward compatible, as long as you are pushing more it's increasing too. it feels very similar to what zwift does i guess. let me know!

@cagnulein cagnulein added this to the 2.18 milestone Nov 28, 2024
@VictorSharov
Copy link

Yes, think the same. Will be great to have a tactile feedback about gear shifting. Since the buttons are a bit stiff, sometimes I don't understand whether is press registered or not. Tactile feedback on Zwift controllers will be more comfort and better. But vibration (haptic feedback) on phone is better than nothing.
What's so hard about getting a vibration command from Zwift? They encrypt the data exchange and it's hard to figure out what command they use for vibration?

@cagnulein
Copy link
Owner

They encrypt the data exchange and it's hard to figure out what command they use for vibration?

yes exactly, i have to figure out which commands send

Copy link

stale bot commented Dec 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 18, 2024
@stale stale bot closed this as completed Dec 28, 2024
@cagnulein cagnulein reopened this Dec 28, 2024
@stale stale bot removed the wontfix This will not be worked on label Dec 28, 2024
cagnulein added a commit that referenced this issue Dec 28, 2024
cagnulein added a commit that referenced this issue Dec 28, 2024
…#2753)

* Tactile Feedback for Zwift Play controllers (and Ride?) (Issue #2752)

* it works!

* vibrate on the right controller
@cagnulein
Copy link
Owner

good news! handled!

@satchafunkilus
Copy link

Just gave it a quick spin. It only vibrated on some shifts (maybe 10-20% of the time) and only with a pretty big delay of a second or so.

debug-Sa__Dez__28_13_31_58_2024.log

@satchafunkilus
Copy link

Appears to be linked to the debouncing. When I turn off debouncing, it vibrates every time, but then also shifts 3-4 gears at once

@cagnulein
Copy link
Owner

@satchafunkilus I'm checking thanks! Strange! With my zwift play it works fine! But for sure there is a explanation!

@cagnulein cagnulein reopened this Dec 28, 2024
@cagnulein
Copy link
Owner

@satchafunkilus Is it possible that it works only when you are going down with the gears and not up?

@cagnulein
Copy link
Owner

I guess I got it, I'm attaching a screen for me as a note
image

@satchafunkilus Just confirm me that it's working only one way. If it's so, I guess I got it

@satchafunkilus
Copy link

@satchafunkilus Is it possible that it works only when you are going down with the gears and not up?

Yes, currently it’s working quite consistently. It vibrates twice on downshifts and not on upshifts.

@cagnulein
Copy link
Owner

cagnulein commented Dec 28, 2024

Perfect I got it, I will send you a new one later today

I tested with zwift play and they have a small little difference

@cagnulein
Copy link
Owner

@satchafunkilus new one sent, let me know!

@satchafunkilus
Copy link

Fix works great now on zwift ride. One suggestion I have is to give a different feedback when you have reached the end of your gears and it cannot shift any further. So if you‘re on gear 1 and try to shift down it could do a triple vibration or a long vibration or something like that. If this is not possible, we could maybe have no vibration in those cases.

@cagnulein
Copy link
Owner

mmm ok i will think about it (because now, in order to send it without latency, i'm doing any control at all). i will play around with it.

@cagnulein
Copy link
Owner

done @satchafunkilus i'm sending you a new one!

@satchafunkilus
Copy link

This is really awesome now. Thanks so much 👌

@cagnulein
Copy link
Owner

@satchafunkilus Amazing! Did you try also the new build with the settings improved? I improved the speed of the settings menu and also I binded the fact that the switch button can switch only if you click on the switch and not to the whole line

@satchafunkilus
Copy link

Yes I did - works fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants