Adb.exe stays resident on QZ exit (Windows)

[victorypoint]

I've been experiencing no auto-incline sometimes when I leave my Zwift/QZ PC on during the day and then turn on the treadmill after several hours to start a Zwift session. I narrowed it down to the ADB.exe process staying in memory on PC. If I kill it, auto-incline works.

I confirmed.. single ADB.exe stays resident on QZ exit - both via quit from menu and x on window bar.

This works to kill adb.exe process..
cmd /c wmic process where name='adb.exe' delete

[cagnulein]

@victorypoint thanks for the feedback, could you check this build? https://github.com/cagnulein/qdomyos-zwift/actions/runs/7420467774

[victorypoint]

@cagnulein, I tested windows-binary.zip and windows-msvc2019-ai-server-binary.zip builds. In each case, adb.exe was not killed when exiting QZ by hitting window x close or Quit from menu.

windows-binary-debug-Fri_Jan_5_11_20_46_2024.log
windows-msvc2019-ai-server-binary1-debug-Fri_Jan_5_11_15_42_2024.log
windows-msvc2019-ai-server-binary2-debug-Fri_Jan_5_11_16_49_2024.log
windows-msvc2019-ai-server-binary3-debug-Fri_Jan_5_11_17_53_2024.log

[cagnulein]

thanks @victorypoint i added some debug log in the terminate function
let's see if i can understand which is the issue
https://github.com/cagnulein/qdomyos-zwift/actions/runs/7423599840

unfortunately i don't have a windows build to try :(

[cagnulein]

sorry wrong link https://github.com/cagnulein/qdomyos-zwift/actions/runs/7423659773

[victorypoint]

@cagnulein, ok new logs attached.

windows-msvc2019-ai-server-binary2-debug-Fri_Jan_5_13_04_23_2024.log
windows-debug-debug-Fri_Jan_5_13_12_42_2024.log

[cagnulein]

ok so QT thinks to did everything right

Fri Jan 5 13:13:31 2024 1704474811139 Debug: nordictrackifitadbtreadmill.cpp void nordictrackifitadbtreadmill::stopLogcatAdbThread() stopLogcatAdbThread()
Fri Jan 5 13:13:31 2024 1704474811141 Debug: nordictrackifitadbtreadmill.cpp void nordictrackifitadbtreadmill::stopLogcatAdbThread() stopLogcatAdbThread() quit
Fri Jan 5 13:13:31 2024 1704474811143 Debug: nordictrackifitadbtreadmill.cpp void nordictrackifitadbtreadmill::stopLogcatAdbThread() stopLogcatAdbThread() terminate
Fri Jan 5 13:13:31 2024 1704474811146 Debug: nordictrackifitadbtreadmill.cpp void nordictrackifitadbtreadmill::stopLogcatAdbThread() stopLogcatAdbThread() wait

Let's try to add this command at the end so

cmd /c wmic process where name='adb.exe' delete

[victorypoint]

@cagnulein, I forgot to mention the QZ terminal window stayed open indefinitely after QZ quit - so seemed to hang.

[cagnulein]

done https://github.com/cagnulein/qdomyos-zwift/actions/runs/7424793324

mmm..that's interesting..I should check what could cause this. let's try this build to see if it was ADB or something else

[victorypoint]

@cagnulein, you nailed it. Adb.exe is killed on exit and no more terminal window hang issue. Nicely done! 👍🎉🥳

[cagnulein]

actually you did it :) Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud Il giorno ven 5 gen 2024 alle 19:18 Al Udell ***@***.***> ha scritto:

…

@cagnulein <https://github.com/cagnulein>, you nailed it. Adb.exe is killed on exit and no more terminal window hang issue. Nicely done! 👍🎉🥳 — Reply to this email directly, view it on GitHub <#1951 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALYWFSEQEEHMWGMFGLI7TYNA7XLAVCNFSM6AAAAABBNIU3AOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGA4DGMRYHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>