Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all submodules agnostic to the state vector order #291

Open
jbreue16 opened this issue Sep 26, 2024 · 0 comments
Open

Make all submodules agnostic to the state vector order #291

jbreue16 opened this issue Sep 26, 2024 · 0 comments

Comments

@jbreue16
Copy link
Contributor

jbreue16 commented Sep 26, 2024

As per discussion in #183 and the #state-seminar-retreat/7, in view of future CADET-Core development, we should make all submodules (convection dispersion operator, binding, reaction, etc) agnostic to the structure of the state vector.
Thats already the case for the convection dispersion operator where we simply pass a stride (two strides in 2D) which defines the stride to the next relevant element.
The binding module however (e.g.) is built on the assumption that all components and bound states are stored continuously.

We can solve this by e.g. passing the strides or a view object (as it is constructed in the DG convection dispersion operator).

For your notice, @schmoelder @AntoniaBerger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant