Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12 compatibility #8

Open
kwadroke opened this issue Jun 22, 2020 · 3 comments
Open

Node 12 compatibility #8

kwadroke opened this issue Jun 22, 2020 · 3 comments

Comments

@kwadroke
Copy link

kwadroke commented Jun 22, 2020

The dependencies versions does not allow this project to run on Node 12 (current Node LTS).

I was able to remove the versions of the dependencies from package.json, then I was able to run it using Node 12.

I also reported this in #cabal.club on IRC.

@okdistribute
Copy link
Member

@kwadroke do you have time to make a Pull Request? It doesn't seem like anyone is actively maintaining it, so PRs definitely welcome!

@kwadroke
Copy link
Author

I'll see what I can do.

@kwadroke
Copy link
Author

kwadroke commented Jun 29, 2020

The irc-client & irc-protocols are dependent on an old version of Mocha which has some big security vulnerabilities. I may have to fork the IRC dependencies and see if I can update them depend on a to newer version of Mocha. It's only used for testing, so hopefully it will be easy.

I did local forks of the IRC deps and removed Mocha from them and the vulnerabilities went away.

Before removing Mocha from irc-client:

found 3 vulnerabilities (1 moderate, 1 high, 1 critical)
run npm audit fix to fix them, or npm audit for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants